Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a97b0d35 authored by Andy Mast's avatar Andy Mast
Browse files

Avoid app install failures from malformed themes 

When an app is installed we create idmaps between it and all the themes
that theme the app. If the theme is really badly written it could
potentially fail idmap generation, but we should not block the app
itself from being installed just because a bad theme is on the device.

Change-Id: I0e38fd373dfd294aac17fab1cf07ba49934a8859
parent 53ac070d

services/java/com/android/server/pm/PackageManagerService.java

+1 −2
Original line number Diff line number Diff line
@@ -5378,8 +5378,7 @@ public class PackageManagerService extends IPackageManager.Stub { 
            // Generate Idmaps if pkg is not a theme

            if (pkg.mOverlayTargets.isEmpty() && mOverlays.containsKey(pkg.packageName)) {

                if (!createIdmapsForPackageLI(pkg)) {

                    mLastScanError = PackageManager.INSTALL_FAILED_THEME_IDMAP_ERROR;

                    return null;

                    Log.w(TAG, "Failed to create idmaps for " + pkg);

                }

            }