Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a96f7af2 authored by Felipe Leme's avatar Felipe Leme
Browse files

Clarified that getAutofillValue() must return same value passed to autofill(). 

Test: m doc-comment-check-docs
Bug: 64114048

Change-Id: I618cc3703db64315a848cc483f460f1b27fec98b
parent 36cbdef8

core/java/android/view/View.java

+9 −5
Original line number Diff line number Diff line
@@ -7452,7 +7452,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
     *       {@link ViewStructure#setAutofillOptions(CharSequence[])}.

     * </ul>

     *

     * <p><b>NOTE:</b> the {@code left} and {@code top} values set in

     * <p><b>Note:</b> The {@code left} and {@code top} values set in

     * {@link ViewStructure#setDimens(int, int, int, int, int, int)} must be relative to the next

     * {@link ViewGroup#isImportantForAutofill()} predecessor view included in the structure.

     *
@@ -7690,6 +7690,10 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
     * {@link AutofillManager#notifyValueChanged(View)} must happen <b>after</b> the value was

     * changed to the autofilled value. If not, the view will not be considered autofilled.

     *

     * <p><b>Note:</b> After this method is called, the value returned by

     * {@link #getAutofillValue()} must be equal to the {@code value} passed to it, otherwise the

     * view will not be highlighted as autofilled.

     *

     * @param value value to be autofilled.

     */

    public void autofill(@SuppressWarnings("unused") AutofillValue value) {
@@ -7713,7 +7717,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
     * <b>after</b> the value was changed to the autofilled value. If not, the child will not be

     * considered autofilled.

     *

     * <p><b>NOTE:</b> to indicate that a virtual view was autofilled,

     * <p><b>Note:</b> To indicate that a virtual view was autofilled,

     * <code>?android:attr/autofilledHighlight</code> should be drawn over it until the data

     * changes.

     *
@@ -7782,8 +7786,8 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
    /**

     * Gets the {@link View}'s current autofill value.

     *

     * <p>By default returns {@code null}, but views should override it to properly support the

     * Autofill Framework.

     * <p>By default returns {@code null}, but subclasses should override it and return an

     * appropriate value to properly support the Autofill Framework.

     *

     * @see #onProvideAutofillStructure(ViewStructure, int)

     * @see #autofill(AutofillValue)
@@ -7835,7 +7839,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
     *       be {@link #IMPORTANT_FOR_AUTOFILL_YES_EXCLUDE_DESCENDANTS}.

     * </ol>

     *

     * <p><b>NOTE:</strong> setting the mode as does {@link #IMPORTANT_FOR_AUTOFILL_NO} or

     * <p><b>Note:</b> Setting the mode as {@link #IMPORTANT_FOR_AUTOFILL_NO} or

     * {@link #IMPORTANT_FOR_AUTOFILL_NO_EXCLUDE_DESCENDANTS} does not guarantee the view (and its

     * children) will be always be considered not important; for example, when the user explicitly

     * makes an autofill request, all views are considered important. See