Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9139bc7 authored by Sehee Park's avatar Sehee Park
Browse files

Add checking permission at the setDataSaverModeEnabled() 



Add calling enforceCallingOrSelfPermission() to check
for NETWORK_SETTINGS permission at the setDataSaverModeEnabled().
When an application calls for setDataSaverModeEnabled() passing a true
parameter, the access to Internet from mobile data became unavailable.

Test: Run test app to call setDataSaverModeEnabled() with a true parameter.
Test: Check the access to Internet from mobile data is available.
Change-Id: I14af89923e61d81355052704081edf121ef7d06d
Signed-off-by: default avatarSehee Park <sehee32.park@samsung.com>
parent 0d75603e

services/core/java/com/android/server/NetworkManagementService.java

+3 −0
Original line number Original line Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.server; 




import static android.Manifest.permission.CONNECTIVITY_INTERNAL;

import static android.Manifest.permission.CONNECTIVITY_INTERNAL;

import static android.Manifest.permission.DUMP;

import static android.Manifest.permission.DUMP;

import static android.Manifest.permission.NETWORK_SETTINGS;

import static android.Manifest.permission.NETWORK_STACK;

import static android.Manifest.permission.NETWORK_STACK;

import static android.Manifest.permission.SHUTDOWN;

import static android.Manifest.permission.SHUTDOWN;

import static android.net.ConnectivityManager.PRIVATE_DNS_DEFAULT_MODE;

import static android.net.ConnectivityManager.PRIVATE_DNS_DEFAULT_MODE;
@@ -1768,6 +1769,8 @@ public class NetworkManagementService extends INetworkManagementService.Stub 




    @Override

    @Override

    public boolean setDataSaverModeEnabled(boolean enable) {

    public boolean setDataSaverModeEnabled(boolean enable) {

        mContext.enforceCallingOrSelfPermission(NETWORK_SETTINGS, TAG);



        if (DBG) Log.d(TAG, "setDataSaverMode: " + enable);

        if (DBG) Log.d(TAG, "setDataSaverMode: " + enable);

        synchronized (mQuotaLock) {

        synchronized (mQuotaLock) {

            if (mDataSaverMode == enable) {

            if (mDataSaverMode == enable) {