Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a90cb087 authored by Brett Chabot's avatar Brett Chabot Committed by Gerrit Code Review
Browse files

Merge changes from topic "cp_slim" 

* changes:
  Lazy load Properties::isDrawingEnabled.
  Backport 'add config to disable snapshots'.
  Backport 'Add ability to disable GL draws'.
parents 982bb0f1 ab73aec1

core/res/res/values/config.xml

+3 −0
Original line number Diff line number Diff line
@@ -5054,4 +5054,7 @@ 


    <!-- the number of the max cached processes in the system. -->

    <integer name="config_customizedMaxCachedProcesses">32</integer>



    <!-- Whether this device should support taking app snapshots on closure -->

    <bool name="config_disableTaskSnapshots">false</bool>

</resources>

core/res/res/values/symbols.xml

+4 −1
Original line number Diff line number Diff line
@@ -4430,4 +4430,7 @@ 
  <java-symbol type="array" name="config_sharedLibrariesLoadedAfterApp" />



  <java-symbol type="integer" name="config_customizedMaxCachedProcesses" />



  <java-symbol type="bool" name="config_disableTaskSnapshots" />



</resources>

graphics/java/android/graphics/HardwareRenderer.java

+52 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ import android.annotation.NonNull; 
import android.annotation.Nullable;

import android.app.Activity;

import android.app.ActivityManager;

import android.compat.annotation.UnsupportedAppUsage;

import android.content.Context;

import android.content.pm.ActivityInfo;

import android.content.res.Configuration;
@@ -1075,6 +1076,53 @@ public class HardwareRenderer { 
        ProcessInitializer.sInstance.setContext(context);

    }



    /**

     * Returns true if HardwareRender will produce output.

     *

     * This value is global to the process and affects all uses of HardwareRenderer,

     * including

     * those created by the system such as those used by the View tree when using hardware

     * accelerated rendering.

     *

     * Default is true in all production environments, but may be false in testing-focused

     * emulators or if {@link #setDrawingEnabled(boolean)} is used.

     *

     * Backported from android T.

     *

     * @hide

     */

    @UnsupportedAppUsage

    public static boolean isDrawingEnabled() {

        return nIsDrawingEnabled();

    }



    /**

     * Toggles whether or not HardwareRenderer will produce drawing output globally in the current

     * process.

     *

     * This applies to all HardwareRenderer instances, including those created by the platform such

     * as those used by the system for hardware accelerated View rendering.

     *

     * The capability to disable drawing output is intended for test environments, primarily

     * headless ones. By setting this to false, tests that launch activities or interact with Views

     * can be quicker with less RAM usage by skipping the final step of View drawing. All View

     * lifecycle events will occur as normal, only the final step of rendering on the GPU to the

     * display will be skipped.

     *

     * This can be toggled on and off at will, so screenshot tests can also run in this same

     * environment by toggling drawing back on and forcing a frame to be drawn such as by calling

     * view#invalidate(). Once drawn and the screenshot captured, this can then be turned back off.

     *

     * Backported from android T.

     *

     * @hide

     */

    // TODO: Add link to androidx's Screenshot library for help with this

    @UnsupportedAppUsage

    public static void setDrawingEnabled(boolean drawingEnabled) {

        nSetDrawingEnabled(drawingEnabled);

    }



    private static final class DestroyContextRunnable implements Runnable {

        private final long mNativeInstance;
@@ -1393,4 +1441,8 @@ public class HardwareRenderer { 


    private static native void nInitDisplayInfo(int width, int height, float refreshRate,

            int wideColorDataspace, long appVsyncOffsetNanos, long presentationDeadlineNanos);



    private static native void nSetDrawingEnabled(boolean drawingEnabled);



    private static native boolean nIsDrawingEnabled();

}

libs/hwui/Properties.cpp

+19 −0
Original line number Diff line number Diff line
@@ -88,6 +88,8 @@ bool Properties::enableWebViewOverlays = false; 


StretchEffectBehavior Properties::stretchEffectBehavior = StretchEffectBehavior::ShaderHWUI;



DrawingEnabled Properties::drawingEnabled = DrawingEnabled::NotInitialized;



bool Properties::load() {

    bool prevDebugLayersUpdates = debugLayersUpdates;

    bool prevDebugOverdraw = debugOverdraw;
@@ -141,6 +143,9 @@ bool Properties::load() { 


    enableWebViewOverlays = base::GetBoolProperty(PROPERTY_WEBVIEW_OVERLAYS_ENABLED, false);



    // call isDrawingEnabled to force loading of the property

    isDrawingEnabled();



    return (prevDebugLayersUpdates != debugLayersUpdates) || (prevDebugOverdraw != debugOverdraw);

}
@@ -210,5 +215,19 @@ void Properties::overrideRenderPipelineType(RenderPipelineType type, bool inUnit 
    sRenderPipelineType = type;

}



void Properties::setDrawingEnabled(bool newDrawingEnabled) {

    drawingEnabled = newDrawingEnabled ? DrawingEnabled::On : DrawingEnabled::Off;

    enableRTAnimations = newDrawingEnabled;

}



bool Properties::isDrawingEnabled() {

    if (drawingEnabled == DrawingEnabled::NotInitialized) {

        bool drawingEnabledProp = base::GetBoolProperty(PROPERTY_DRAWING_ENABLED, true);

        drawingEnabled = drawingEnabledProp ? DrawingEnabled::On : DrawingEnabled::Off;

        enableRTAnimations = drawingEnabledProp;

    }

    return drawingEnabled == DrawingEnabled::On;

}



}  // namespace uirenderer

}  // namespace android

libs/hwui/Properties.h

+13 −0
Original line number Diff line number Diff line
@@ -187,6 +187,12 @@ enum DebugLevel { 
 */

#define PROPERTY_WEBVIEW_OVERLAYS_ENABLED "debug.hwui.webview_overlays_enabled"



/**

 * Property for globally GL drawing state. Can be overridden per process with

 * setDrawingEnabled.

 */

#define PROPERTY_DRAWING_ENABLED "debug.hwui.drawing_enabled"



///////////////////////////////////////////////////////////////////////////////

// Misc

///////////////////////////////////////////////////////////////////////////////
@@ -208,6 +214,8 @@ enum class StretchEffectBehavior { 
    UniformScale  // Uniform scale stretch everywhere

};



enum class DrawingEnabled { NotInitialized, On, Off };



/**

 * Renderthread-only singleton which manages several static rendering properties. Most of these

 * are driven by system properties which are queried once at initialization, and again if init()
@@ -301,6 +309,11 @@ public: 
        stretchEffectBehavior = behavior;

    }



    // Represents if drawing is enabled. Should only be Off in headless testing environments

    static DrawingEnabled drawingEnabled;

    static bool isDrawingEnabled();

    static void setDrawingEnabled(bool enable);



private:

    static StretchEffectBehavior stretchEffectBehavior;

    static ProfileType sProfileType;