Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a865790a authored by Hugo Benichi's avatar Hugo Benichi
Browse files

DO NOT MERGE Stricter NetworkNotificationManagerTest 

This patch changes NetworkNotificationManagerTest to populate extraInfo
of NetworkInfo in order to catch regressions in malformed format Strings
of log statements in NetworkNotificationManager.

Test: verified that the test fails when reintroducing the format String
bug.
Bug: 33737715

Change-Id: If14063554b8246d9d80cd222cb41c30dee121c5a
parent 7eaec196

tests/net/java/com/android/server/connectivity/NetworkNotificationManagerTest.java→services/tests/servicestests/src/com/android/server/connectivity/NetworkNotificationManagerTest.java

+1 −0
Original line number Diff line number Diff line
@@ -80,6 +80,7 @@ public class NetworkNotificationManagerTest extends TestCase { 
        when(mCtx.getResources()).thenReturn(mResources);

        when(mCtx.getPackageManager()).thenReturn(mPm);

        when(mCtx.getApplicationInfo()).thenReturn(new ApplicationInfo());

        when(mNetworkInfo.getExtraInfo()).thenReturn("extra");

        when(mResources.getColor(anyInt(), any())).thenReturn(0xFF607D8B);



        mManager = new NetworkNotificationManager(mCtx, mTelephonyManager, mNotificationManager);

services/core/java/com/android/server/connectivity/NetworkNotificationManager.java

+1 −1

File changed.

Contains only whitespace changes.