Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a823068e authored by Dmitry Dementyev's avatar Dmitry Dementyev Committed by Android (Google) Code Review
Browse files

Merge "Remove finalizer which clears user secret at unpredictable time."

parents e7ed6aad 19da3400
Loading
Loading
Loading
Loading
+1 −11
Original line number Diff line number Diff line
@@ -235,17 +235,7 @@ public final class KeyChainProtectionParams implements Parcelable {
    }

    /**
     * Removes secret from memory than object is no longer used.
     * Since finalizer call is not reliable, please use @link {#clearSecret} directly.
     */
    @Override
    protected void finalize() throws Throwable {
        clearSecret();
        super.finalize();
    }

    /**
     * Fills mSecret with zeroes.
     * Fills secret with zeroes.
     */
    public void clearSecret() {
        Arrays.fill(mSecret, (byte) 0);