Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a80838d9 authored by Jean Chalard's avatar Jean Chalard
Browse files

Fix a warning from the binder. 

This patch fixes the following warning:
W/Binder: The following Binder class should be static or
  leaks might occur: android.view.textservice
  .SpellCheckerSession.InternalListener

...in hope of removing a possible memory leaks.
However in my tests it does nothing at all for the memory leak
in bug 5461066, so it was probably unrelated.

Change-Id: Id776665e9483121d22cc91e8d2d9f32e3413ec96
Bugs: 5481376,5461066
parent 149a1493

core/java/android/view/textservice/SpellCheckerSession.java

+9 −3
Original line number Diff line number Diff line
@@ -123,7 +123,7 @@ public class SpellCheckerSession { 
        }

        mSpellCheckerInfo = info;

        mSpellCheckerSessionListenerImpl = new SpellCheckerSessionListenerImpl(mHandler);

        mInternalListener = new InternalListener();

        mInternalListener = new InternalListener(mSpellCheckerSessionListenerImpl);

        mTextServicesManager = tsm;

        mIsUsed = true;

        mSpellCheckerSessionListener = listener;
@@ -316,13 +316,19 @@ public class SpellCheckerSession { 
        public void onGetSuggestions(SuggestionsInfo[] results);

    }



    private class InternalListener extends ITextServicesSessionListener.Stub {

    private static class InternalListener extends ITextServicesSessionListener.Stub {

        private final SpellCheckerSessionListenerImpl mParentSpellCheckerSessionListenerImpl;



        public InternalListener(SpellCheckerSessionListenerImpl spellCheckerSessionListenerImpl) {

            mParentSpellCheckerSessionListenerImpl = spellCheckerSessionListenerImpl;

        }



        @Override

        public void onServiceConnected(ISpellCheckerSession session) {

            if (DBG) {

                Log.w(TAG, "SpellCheckerSession connected.");

            }

            mSpellCheckerSessionListenerImpl.onServiceConnected(session);

            mParentSpellCheckerSessionListenerImpl.onServiceConnected(session);

        }

    }