Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7f3e9c7 authored by Felipe Leme's avatar Felipe Leme
Browse files

Revert "Always set FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE on SaveInfo when on compat mode." 

Save has many limitations on compat mode, so we better not change the SaveInfo
behavior but rather document then.

This reverts commit 4f74a018.

Test: atest CtsAutoFillServiceTestCases:VirtualContainerActivityTest \
CtsAutoFillServiceTestCases:VirtualContainerActivityCompatModeTest

Bug: 77655074

Change-Id: I36bd28ca546dcedefe75de7815b76b8b5827aee3
parent 3f888482

core/java/android/service/autofill/AutofillService.java

+0 −3
Original line number Diff line number Diff line
@@ -527,9 +527,6 @@ import android.view.autofill.AutofillValue; 
 * <pre> &lt;autofill-service xmlns:android="http://schemas.android.com/apk/res/android"&gt;

 *     &lt;compatibility-package android:name="foo.bar.baz" android:maxLongVersionCode="1000000000"/&gt;

 * &lt;/autofill-service&gt;</pre>

 *

 * <p>When using compatibility mode, the {@link SaveInfo.Builder#setFlags(int) SaveInfo flags}

 * automatically include {@link SaveInfo#FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE}.

 */

public abstract class AutofillService extends Service {

    private static final String TAG = "AutofillService";

services/autofill/java/com/android/server/autofill/Session.java

+2 −5
Original line number Diff line number Diff line
@@ -2151,11 +2151,8 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState 
            if (saveTriggerId != null) {

                writeLog(MetricsEvent.AUTOFILL_EXPLICIT_SAVE_TRIGGER_DEFINITION);

            }

            int flags = saveInfo.getFlags();

            if (mCompatMode) {

                flags |= SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE;

            }

            mSaveOnAllViewsInvisible = (flags & SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE) != 0;

            mSaveOnAllViewsInvisible =

                    (saveInfo.getFlags() & SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE) != 0;



            // We only need to track views if we want to save once they become invisible.

            if (mSaveOnAllViewsInvisible) {