Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7cb6978 authored by Zhen Zhang's avatar Zhen Zhang
Browse files

Don't let RecyclerView consume fling action when there is no further space. 

Before dispatch nested fling, check if there is any further space available
in the requested direction. If yes, set consumed to true; otherwise, false.
This can help list area in sharesheet responds to fling action to collapse.

Bug: 145998887
Test: manually tests. Fling down list area
will collapse sharesheet when list area reach its top edge; otherwise,
the list area itself will fling.

Change-Id: I060a1a91d6bdb0f3d6d0f825b065449223593bfc
parent 8e958350

core/java/com/android/internal/widget/RecyclerView.java

+16 −2
Original line number Diff line number Diff line
@@ -2011,13 +2011,27 @@ public class RecyclerView extends ViewGroup implements ScrollingView, NestedScro 
        }















        if (!dispatchNestedPreFling(velocityX, velocityY)) {













            final boolean canScroll = canScrollHorizontal || canScrollVertical;













            dispatchNestedFling(velocityX, velocityY, canScroll);













            final View firstChild = mLayout.getChildAt(0);













            final View lastChild = mLayout.getChildAt(mLayout.getChildCount() - 1);













            boolean consumed = false;













            if (velocityY < 0) {













                consumed = getChildAdapterPosition(firstChild) > 0













                        || firstChild.getTop() < getPaddingTop();













            }

























            if (velocityY > 0) {













                consumed = getChildAdapterPosition(lastChild) < mAdapter.getItemCount() - 1













                        || lastChild.getBottom() > getHeight() - getPaddingBottom();













            }

























            dispatchNestedFling(velocityX, velocityY, consumed);





























            if (mOnFlingListener != null && mOnFlingListener.onFling(velocityX, velocityY)) {















                return true;















            }



























            final boolean canScroll = canScrollHorizontal || canScrollVertical;



























            if (canScroll) {















                velocityX = Math.max(-mMaxFlingVelocity, Math.min(velocityX, mMaxFlingVelocity));















                velocityY = Math.max(-mMaxFlingVelocity, Math.min(velocityY, mMaxFlingVelocity));