Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7c50568 authored by Vincent Wang's avatar Vincent Wang
Browse files

Fix biometric context update problem. 

Bug: b/288761850
Test: Check b/288761850
Change-Id: I890d102d10a3efa230e26e4e9753f9c66b71afdb
parent fb4a3c34

services/core/java/com/android/server/biometrics/log/BiometricContextProvider.java

+4 −0
Original line number Diff line number Diff line
@@ -216,6 +216,10 @@ public final class BiometricContextProvider implements BiometricContext { 
    public void subscribe(@NonNull OperationContextExt context,

            @NonNull Consumer<OperationContext> consumer) {

        mSubscribers.put(context, consumer);

        // TODO(b/294161627) Combine the getContext/subscribe APIs to avoid race

        if (context.getDisplayState() != getDisplayState()) {

            consumer.accept(context.update(this, context.isCrypto()).toAidlContext());

        }

    }



    @Override

services/tests/servicestests/src/com/android/server/biometrics/log/BiometricContextProviderTest.java

+11 −0
Original line number Diff line number Diff line
@@ -251,6 +251,14 @@ public class BiometricContextProviderTest { 
        assertThat(actual).containsExactly(true, false, true, true, false, false).inOrder();

    }



    @Test

    public void testSubscribesWithDifferentState() throws RemoteException {

        final Consumer<OperationContext> nonEmptyConsumer = mock(Consumer.class);

        mListener.onDisplayStateChanged(AuthenticateOptions.DISPLAY_STATE_AOD);

        mProvider.subscribe(mOpContext, nonEmptyConsumer);

        verify(nonEmptyConsumer).accept(same(mOpContext.toAidlContext()));

    }



    @Test

    public void testUnsubscribes() throws RemoteException {

        final Consumer<OperationContext> emptyConsumer = mock(Consumer.class);
@@ -259,6 +267,9 @@ public class BiometricContextProviderTest { 


        mListener.onDisplayStateChanged(AuthenticateOptions.DISPLAY_STATE_AOD);



        //reset to unknown to avoid trigger accept when subscribe

        mListener.onDisplayStateChanged(AuthenticateOptions.DISPLAY_STATE_UNKNOWN);



        final Consumer<OperationContext> nonEmptyConsumer = mock(Consumer.class);

        mProvider.subscribe(mOpContext, nonEmptyConsumer);

        mListener.onDisplayStateChanged(AuthenticateOptions.DISPLAY_STATE_LOCKSCREEN);