Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7b7de59 authored by Ryan Mitchell's avatar Ryan Mitchell
Browse files

Fix idmap2 uninitialized variables 

Some primitives were not initialized to a default value causing
--ignore-overlayable and --verbose to default to true.

Bug: 148181123
Test: idmap2_tests
Change-Id: If87ba76b7d24803f46b71ef36befa12f25916680
Merged-In: Ic9dbd3e9a768beb39ac677ff294b0fca5ee8f9d2
parent 32f87fc6

cmds/idmap2/idmap2/Create.cpp

+1 −1
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ Result<Unit> Create(const std::vector<std::string>& args) { 
  std::string overlay_apk_path;

  std::string idmap_path;

  std::vector<std::string> policies;

  bool ignore_overlayable;

  bool ignore_overlayable = false;



  const CommandLineOptions opts =

      CommandLineOptions("idmap2 create")

cmds/idmap2/idmap2/Dump.cpp

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ using android::idmap2::Unit; 
Result<Unit> Dump(const std::vector<std::string>& args) {

  SYSTRACE << "Dump " << args;

  std::string idmap_path;

  bool verbose;

  bool verbose = false;



  const CommandLineOptions opts =

      CommandLineOptions("idmap2 dump")

cmds/idmap2/tests/Idmap2BinaryTests.cpp

+0 −1
Original line number Diff line number Diff line
@@ -131,7 +131,6 @@ TEST_F(Idmap2BinaryTests, Dump) { 
  ASSERT_NE(result->stdout.find("0x7f02000c -> 0x7f020000 string/str1"), std::string::npos);

  ASSERT_NE(result->stdout.find("0x7f02000e -> 0x7f020001 string/str3"), std::string::npos);

  ASSERT_NE(result->stdout.find("0x7f02000f -> 0x7f020002 string/str4"), std::string::npos);

  ASSERT_EQ(result->stdout.find("00000210:     007f  target package id"), std::string::npos);



  // clang-format off

  result = ExecuteBinary({"idmap2",