Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a6b653f2 authored by Julia Reynolds's avatar Julia Reynolds
Browse files

Mute new assistant stream in total silence mode 

Test: atest
Fixes: 149220546
Change-Id: I4e263717c9d4e8187376e141927d2b5616a14eb3
parent a80e3217

services/core/java/com/android/server/notification/ZenModeHelper.java

+6 −3
Original line number Original line Diff line number Diff line
@@ -1278,13 +1278,16 @@ public class ZenModeHelper { 
                    (1 << AudioSystem.STREAM_SYSTEM);

                    (1 << AudioSystem.STREAM_SYSTEM);





            if (mZenMode == Global.ZEN_MODE_NO_INTERRUPTIONS) {

            if (mZenMode == Global.ZEN_MODE_NO_INTERRUPTIONS) {

                // alarm and music streams affected by ringer mode (cannot be adjusted) when in

                // alarm and music and streams affected by ringer mode (cannot be adjusted) when in

                // total silence

                // total silence

                streams |= (1 << AudioSystem.STREAM_ALARM) |

                streams |= (1 << AudioSystem.STREAM_ALARM) |

                        (1 << AudioSystem.STREAM_MUSIC);

                        (1 << AudioSystem.STREAM_MUSIC) |

                        (1 << AudioSystem.STREAM_ASSISTANT);

            } else {

            } else {

                streams &= ~((1 << AudioSystem.STREAM_ALARM) |

                streams &= ~((1 << AudioSystem.STREAM_ALARM) |

                        (1 << AudioSystem.STREAM_MUSIC));

                        (1 << AudioSystem.STREAM_MUSIC) |

                        (1 << AudioSystem.STREAM_ASSISTANT)

                );

            }

            }

            return streams;

            return streams;

        }

        }

services/tests/uiservicestests/src/com/android/server/notification/ZenModeHelperTest.java

+3 −0
Original line number Original line Diff line number Diff line
@@ -559,6 +559,7 @@ public class ZenModeHelperTest extends UiServiceTestCase { 
        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_SYSTEM)) != 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_SYSTEM)) != 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_ALARM)) != 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_ALARM)) != 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_MUSIC)) != 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_MUSIC)) != 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_ASSISTANT)) != 0);

    }

    }





    @Test

    @Test
@@ -579,6 +580,7 @@ public class ZenModeHelperTest extends UiServiceTestCase { 
        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_SYSTEM)) != 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_SYSTEM)) != 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_ALARM)) == 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_ALARM)) == 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_MUSIC)) == 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_MUSIC)) == 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_ASSISTANT)) == 0);





        // even when ringer is muted (since all ringer sounds cannot bypass DND),

        // even when ringer is muted (since all ringer sounds cannot bypass DND),

        // system stream is still affected by ringer mode

        // system stream is still affected by ringer mode
@@ -601,6 +603,7 @@ public class ZenModeHelperTest extends UiServiceTestCase { 
                != 0);

                != 0);

        assertTrue((ringerMutedRingerModeAffectedStreams & (1 << AudioSystem.STREAM_ALARM)) == 0);

        assertTrue((ringerMutedRingerModeAffectedStreams & (1 << AudioSystem.STREAM_ALARM)) == 0);

        assertTrue((ringerMutedRingerModeAffectedStreams & (1 << AudioSystem.STREAM_MUSIC)) == 0);

        assertTrue((ringerMutedRingerModeAffectedStreams & (1 << AudioSystem.STREAM_MUSIC)) == 0);

        assertTrue((ringerModeAffectedStreams & (1 << AudioSystem.STREAM_ASSISTANT)) == 0);

    }

    }





    @Test

    @Test