Merge "Check group channels for FGSes" (a6978c8f) · Commits · e / os / android_frameworks_base

services/core/java/com/android/server/notification/NotificationManagerService.java

+3 −2

Original line number	Diff line number	Diff line
		@@ -2766,7 +2766,7 @@ public class NotificationManagerService extends SystemService {
		}
		}

		private void createNotificationChannelGroup(String pkg, int uid, NotificationChannelGroup group,
		void createNotificationChannelGroup(String pkg, int uid, NotificationChannelGroup group,
		boolean fromApp, boolean fromListener) {
		Objects.requireNonNull(group);
		Objects.requireNonNull(pkg);
		@@ -3822,7 +3822,8 @@ public class NotificationManagerService extends SystemService {

		final int callingUid = Binder.getCallingUid();
		NotificationChannelGroup groupToDelete =
		mPreferencesHelper.getNotificationChannelGroup(groupId, pkg, callingUid);
		mPreferencesHelper.getNotificationChannelGroupWithChannels(
		pkg, callingUid, groupId, false);
		if (groupToDelete != null) {
		// Preflight for allowability
		final int userId = UserHandle.getUserId(callingUid);

services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java

+51 −1

Original line number	Diff line number	Diff line
		@@ -235,6 +235,7 @@ import java.util.Arrays;
		import java.util.Collections;
		import java.util.List;
		import java.util.Map;
		import java.util.concurrent.CountDownLatch;
		import java.util.function.Consumer;


		@@ -2892,7 +2893,8 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {
		.thenReturn(singletonList(mock(AssociationInfo.class)));
		NotificationChannelGroup ncg = new NotificationChannelGroup("a", "b/c");
		mService.setPreferencesHelper(mPreferencesHelper);
		when(mPreferencesHelper.getNotificationChannelGroup(eq(ncg.getId()), eq(PKG), anyInt()))
		when(mPreferencesHelper.getNotificationChannelGroupWithChannels(
		eq(PKG), anyInt(), eq(ncg.getId()), anyBoolean()))
		.thenReturn(ncg);
		reset(mListeners);
		mBinderService.deleteNotificationChannelGroup(PKG, ncg.getId());
		@@ -2901,6 +2903,54 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {
		eq(NotificationListenerService.NOTIFICATION_CHANNEL_OR_GROUP_DELETED));
		}

		@Test
		public void testDeleteChannelGroupChecksForFgses() throws Exception {
		when(mCompanionMgr.getAssociations(PKG, UserHandle.getUserId(mUid)))
		.thenReturn(singletonList(mock(AssociationInfo.class)));
		CountDownLatch latch = new CountDownLatch(2);
		mService.createNotificationChannelGroup(
		PKG, mUid, new NotificationChannelGroup("group", "group"), true, false);
		new Thread(() -> {
		NotificationChannel notificationChannel = new NotificationChannel("id", "id",
		NotificationManager.IMPORTANCE_HIGH);
		notificationChannel.setGroup("group");
		ParceledListSlice<NotificationChannel> pls =
		new ParceledListSlice(ImmutableList.of(notificationChannel));
		try {
		mBinderService.createNotificationChannelsForPackage(PKG, mUid, pls);
		} catch (RemoteException e) {
		throw new RuntimeException(e);
		}
		latch.countDown();
		}).start();
		new Thread(() -> {
		try {
		synchronized (this) {
		wait(5000);
		}
		mService.createNotificationChannelGroup(PKG, mUid,
		new NotificationChannelGroup("new", "new group"), true, false);
		NotificationChannel notificationChannel =
		new NotificationChannel("id", "id", NotificationManager.IMPORTANCE_HIGH);
		notificationChannel.setGroup("new");
		ParceledListSlice<NotificationChannel> pls =
		new ParceledListSlice(ImmutableList.of(notificationChannel));
		try {
		mBinderService.createNotificationChannelsForPackage(PKG, mUid, pls);
		mBinderService.deleteNotificationChannelGroup(PKG, "group");
		} catch (RemoteException e) {
		throw new RuntimeException(e);
		}
		} catch (Exception e) {
		e.printStackTrace();
		}
		latch.countDown();
		}).start();

		latch.await();
		verify(mAmi).hasForegroundServiceNotification(anyString(), anyInt(), anyString());
		}

		@Test
		public void testUpdateNotificationChannelFromPrivilegedListener_success() throws Exception {
		mService.setPreferencesHelper(mPreferencesHelper);