Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a61f3959 authored by Perry Wu's avatar Perry Wu
Browse files

Only update home visibility on exit pip to fullscreen 

In ag/27443168 we update home visibility when expanding pip to
fix a bug with overview. However this introduced a new bug where
taskbar would appear when home was not visible.

This fixes the second issue by only updating home visibility when
we actually expand pip.

Flag: N/A
Bug: 342529469
Test: Manually verify taskbar doesn't appear when dismissing pip,
and that we have not regressed b/340443311 when expanding pip

Change-Id: I341118278faebf446800f89572176a3e52b5bb95
(cherry picked from commit 2f3aa427)
parent fd07c424

libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java

+3 −3
Original line number Original line Diff line number Diff line
@@ -201,9 +201,6 @@ public class PipTransition extends PipTransitionController { 
            animator.cancel();

            animator.cancel();

        }

        }

        mExitTransition = mTransitions.startTransition(type, out, this);

        mExitTransition = mTransitions.startTransition(type, out, this);

        if (mPipOrganizer.getOutPipWindowingMode() == WINDOWING_MODE_UNDEFINED) {

            mHomeTransitionObserver.notifyHomeVisibilityChanged(false /* isVisible */);

        }

    }

    }





    @Override

    @Override
@@ -645,6 +642,9 @@ public class PipTransition extends PipTransitionController { 
            startTransaction.remove(mPipOrganizer.mPipOverlay);

            startTransaction.remove(mPipOrganizer.mPipOverlay);

            mPipOrganizer.clearContentOverlay();

            mPipOrganizer.clearContentOverlay();

        }

        }

        if (mPipOrganizer.getOutPipWindowingMode() == WINDOWING_MODE_UNDEFINED) {

            mHomeTransitionObserver.notifyHomeVisibilityChanged(false /* isVisible */);

        }

        if (pipChange == null) {

        if (pipChange == null) {

            ProtoLog.w(ShellProtoLogGroup.WM_SHELL_PICTURE_IN_PICTURE,

            ProtoLog.w(ShellProtoLogGroup.WM_SHELL_PICTURE_IN_PICTURE,

                    "%s: No window of exiting PIP is found. Can't play expand animation", TAG);

                    "%s: No window of exiting PIP is found. Can't play expand animation", TAG);