Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5bacea4 authored by Milo Sredkov's avatar Milo Sredkov
Browse files

Address visual inconsistency in smart replies 

Address the major style differences and make the smart reply buttons
fit better with the other notification UI elements.

This CL does not yet address all the isues but removes the most
obvious inconsistencies.

Screenshot before: https://screenshot.googleplex.com/90QVvxJmUJ3.png
Screenshot after: https://screenshot.googleplex.com/2C8cMQgTVBG.png

Bug: 73605520
Test: In Notify post a Messaging notification with Large chices

Change-Id: Ide285c21c7bf83e9f06ade6912fd13cb3e4b9024
parent 8d1ff46d

packages/SystemUI/res/drawable/smart_reply_button_background.xml

+11 −6
Original line number Diff line number Diff line
@@ -19,11 +19,16 @@ 
<ripple xmlns:android="http://schemas.android.com/apk/res/android"

        android:color="@color/notification_ripple_untinted_color">

    <item>

        <inset

            android:insetLeft="0dp"

            android:insetTop="7dp"

            android:insetRight="0dp"

            android:insetBottom="5dp">

            <shape android:shape="rectangle">

            <!-- Use non-zero corner radius to work around b/73285195. The actual corner radius is

                 set dynamically at runtime in SmartReplyView. -->

            <corners android:radius="1dp"/>

                <corners android:radius="8dp" />

                <stroke android:width="1dp" android:color="@color/smart_reply_button_stroke" />

                <solid android:color="@color/smart_reply_button_background"/>

            </shape>

        </inset>

    </item>

</ripple>

packages/SystemUI/res/layout/smart_reply_button.xml

+3 −3
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ 


<!-- android:paddingHorizontal is set dynamically in SmartReplyView. -->

<Button xmlns:android="http://schemas.android.com/apk/res/android"

        style="@android:style/Widget.Material.Button.Borderless.Small"

        style="@android:style/Widget.Material.Button"

        android:layout_width="wrap_content"

        android:layout_height="match_parent"

        android:minWidth="0dp"
@@ -26,7 +26,7 @@ 
        android:paddingVertical="@dimen/smart_reply_button_padding_vertical"

        android:background="@drawable/smart_reply_button_background"

        android:gravity="center"

        android:fontFamily="sans-serif"

        android:fontFamily="sans-serif-medium"

        android:textSize="@dimen/smart_reply_button_font_size"

        android:lineSpacingExtra="@dimen/smart_reply_button_line_spacing_extra"

        android:textColor="@color/smart_reply_button_text"

packages/SystemUI/res/layout/smart_reply_view.xml

+2 −1
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 
    android:id="@+id/smart_reply_view"

    android:layout_height="wrap_content"

    android:layout_width="wrap_content"

    android:layout_marginStart="12dp"

    systemui:spacing="@dimen/smart_reply_button_spacing"

    systemui:singleLineButtonPaddingHorizontal="@dimen/smart_reply_button_padding_horizontal_single_line"

    systemui:doubleLineButtonPaddingHorizontal="@dimen/smart_reply_button_padding_horizontal_double_line">

packages/SystemUI/res/values/colors.xml

+3 −2
Original line number Diff line number Diff line
@@ -150,8 +150,9 @@ 


    <color name="zen_introduction">#ffffffff</color>



    <color name="smart_reply_button_text">#de000000</color> <!-- 87% black -->

    <color name="smart_reply_button_background">#fff2f2f2</color>

    <color name="smart_reply_button_text">#5F6368</color>

    <color name="smart_reply_button_background">#feffffff</color>

    <color name="smart_reply_button_stroke">#ffdadce0</color>



    <!-- Fingerprint dialog colors -->

    <color name="fingerprint_dialog_bg_color">#ffffffff</color> <!-- 100% white -->

packages/SystemUI/res/values/dimens.xml

+2 −2
Original line number Diff line number Diff line
@@ -932,9 +932,9 @@ 
    <!-- Smart reply button -->

    <dimen name="smart_reply_button_spacing">8dp</dimen>

    <dimen name="smart_reply_button_padding_vertical">10dp</dimen>

    <dimen name="smart_reply_button_padding_horizontal_single_line">12dp</dimen>

    <dimen name="smart_reply_button_padding_horizontal_single_line">16dp</dimen>

    <dimen name="smart_reply_button_padding_horizontal_double_line">16dp</dimen>

    <dimen name="smart_reply_button_min_height">40dp</dimen>

    <dimen name="smart_reply_button_min_height">32dp</dimen>

    <dimen name="smart_reply_button_font_size">14sp</dimen>

    <dimen name="smart_reply_button_line_spacing_extra">6sp</dimen> <!-- Total line height 20sp. -->