Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5043ed7 authored by Nick Kralevich's avatar Nick Kralevich
Browse files

AppSecurityPermissions: Modify isDisplayablePermission 

Add optional permission support to isDisplayablePermission.

A permission is displayable if it's required, or was previously
granted to the app.

Currently, this change is a no-op. The package parser code
does not currently honor <uses-permission android:required="false"> in
the application's manifest, and assumes a permission is always required.

This change sets the ground for future optional permissions work.

Change-Id: I2ec4a49adbfab9980e116ed43354f16bdeaa301d
parent d6182f99

core/java/android/widget/AppSecurityPermissions.java

+14 −5
Original line number Diff line number Diff line
@@ -507,16 +507,25 @@ public class AppSecurityPermissions { 
    private boolean isDisplayablePermission(PermissionInfo pInfo, int newReqFlags,

            int existingReqFlags) {

        final int base = pInfo.protectionLevel & PermissionInfo.PROTECTION_MASK_BASE;

        // Dangerous and normal permissions are always shown to the user.

        if (base == PermissionInfo.PROTECTION_DANGEROUS ||

                base == PermissionInfo.PROTECTION_NORMAL) {

        final boolean isNormal = (base == PermissionInfo.PROTECTION_NORMAL);

        final boolean isDangerous = (base == PermissionInfo.PROTECTION_DANGEROUS);

        final boolean isRequired =

                ((newReqFlags&PackageInfo.REQUESTED_PERMISSION_REQUIRED) != 0);

        final boolean isDevelopment =

                ((pInfo.protectionLevel&PermissionInfo.PROTECTION_FLAG_DEVELOPMENT) != 0);

        final boolean wasGranted =

                ((existingReqFlags&PackageInfo.REQUESTED_PERMISSION_GRANTED) != 0);



        // Dangerous and normal permissions are always shown to the user if the permission

        // is required, or it was previously granted

        if ((isNormal || isDangerous) && (isRequired || wasGranted)) {

            return true;

        }



        // Development permissions are only shown to the user if they are already

        // granted to the app -- if we are installing an app and they are not

        // already granted, they will not be granted as part of the install.

        if ((existingReqFlags&PackageInfo.REQUESTED_PERMISSION_GRANTED) != 0

                && (pInfo.protectionLevel & PermissionInfo.PROTECTION_FLAG_DEVELOPMENT) != 0) {

        if (isDevelopment && wasGranted) {

            if (localLOGV) Log.i(TAG, "Special perm " + pInfo.name

                    + ": protlevel=0x" + Integer.toHexString(pInfo.protectionLevel));

            return true;