Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4a8be37 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "AImageDecoder: ensure that stride is pixel aligned"

parents 992ba2dd d894c598
Loading
Loading
Loading
Loading
+3 −5
Original line number Diff line number Diff line
@@ -325,11 +325,9 @@ int AImageDecoder_decodeImage(AImageDecoder* decoder,

    ImageDecoder* imageDecoder = toDecoder(decoder);

    const int height = imageDecoder->getOutputInfo().height();
    const size_t minStride = AImageDecoder_getMinimumStride(decoder);
    // If this calculation were to overflow, it would have been caught in
    // setTargetSize.
    if (stride < minStride || size < stride * (height - 1) + minStride) {
    SkImageInfo info = imageDecoder->getOutputInfo();
    size_t minSize = info.computeByteSize(stride);
    if (SkImageInfo::ByteSizeOverflowed(minSize) || size < minSize || !info.validRowBytes(stride)) {
        return ANDROID_IMAGE_DECODER_BAD_PARAMETER;
    }