Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a3941ec1 authored by Caitlin Shkuratov's avatar Caitlin Shkuratov
Browse files

[SB][Chips] Only compose the chips if we have chips to show. 

Recomposition is expensive and can cause performance regressions,
so don't compose the chips at all unless we know we have chips to show.

Fixes: 401241197
Bug: 372657935
Flag: com.android.systemui.status_bar_chips_modernization
Test: smoke test of chips (adding + removing all types of chips)
Change-Id: I553d74342f347467951aeeb10aa4b72e30f38c94
parent 54d27f03

packages/SystemUI/src/com/android/systemui/statusbar/chips/ui/compose/OngoingActivityChips.kt

+13 −12
Original line number Diff line number Diff line
@@ -36,6 +36,8 @@ fun OngoingActivityChips( 
    iconViewStore: NotificationIconContainerViewBinder.IconViewStore?,

    modifier: Modifier = Modifier,

) {

    val shownChips = chips.active.filter { !it.isHidden }

    if (shownChips.isNotEmpty()) {

        Row(

            modifier =

                modifier
@@ -45,9 +47,7 @@ fun OngoingActivityChips( 
            horizontalArrangement =

                Arrangement.spacedBy(dimensionResource(R.dimen.ongoing_activity_chip_margin_start)),

        ) {

        chips.active

            .filter { !it.isHidden }

            .forEach {

            shownChips.forEach {

                key(it.key) {

                    OngoingActivityChip(

                        model = it,
@@ -58,3 +58,4 @@ fun OngoingActivityChips( 
            }

        }

    }

}