Merge "Synchronize adapter registration with mCallbacks" (a37b682e) · Commits · e / os / android_frameworks_base

services/core/java/com/android/server/BluetoothManagerService.java

+30 −40

Original line number	Diff line number	Diff line
		@@ -113,8 +113,6 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
		private static final int MESSAGE_DISABLE = 2;
		private static final int MESSAGE_HANDLE_ENABLE_DELAYED = 3;
		private static final int MESSAGE_HANDLE_DISABLE_DELAYED = 4;
		private static final int MESSAGE_REGISTER_ADAPTER = 20;
		private static final int MESSAGE_UNREGISTER_ADAPTER = 21;
		private static final int MESSAGE_REGISTER_STATE_CHANGE_CALLBACK = 30;
		private static final int MESSAGE_UNREGISTER_STATE_CHANGE_CALLBACK = 31;
		private static final int MESSAGE_BLUETOOTH_SERVICE_CONNECTED = 40;
		@@ -590,10 +588,9 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
		Slog.w(TAG, "Callback is null in registerAdapter");
		return null;
		}
		Message msg = mHandler.obtainMessage(MESSAGE_REGISTER_ADAPTER);
		msg.obj = callback;
		mHandler.sendMessage(msg);

		synchronized (mCallbacks) {
		mCallbacks.register(callback);
		}
		return mBluetooth;
		}

		@@ -603,9 +600,9 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
		return;
		}
		mContext.enforceCallingOrSelfPermission(BLUETOOTH_PERM, "Need BLUETOOTH permission");
		Message msg = mHandler.obtainMessage(MESSAGE_UNREGISTER_ADAPTER);
		msg.obj = callback;
		mHandler.sendMessage(msg);
		synchronized (mCallbacks) {
		mCallbacks.unregister(callback);
		}
		}

		public void registerStateChangeCallback(IBluetoothStateChangeCallback callback) {
		@@ -1478,6 +1475,7 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
		* Inform BluetoothAdapter instances that Adapter service is up
		*/
		private void sendBluetoothServiceUpCallback() {
		synchronized (mCallbacks) {
		try {
		int n = mCallbacks.beginBroadcast();
		Slog.d(TAG, "Broadcasting onBluetoothServiceUp() to " + n + " receivers.");
		@@ -1492,11 +1490,13 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
		mCallbacks.finishBroadcast();
		}
		}
		}

		/**
		* Inform BluetoothAdapter instances that Adapter service is down
		*/
		private void sendBluetoothServiceDownCallback() {
		synchronized (mCallbacks) {
		try {
		int n = mCallbacks.beginBroadcast();
		Slog.d(TAG, "Broadcasting onBluetoothServiceDown() to " + n + " receivers.");
		@@ -1511,6 +1511,7 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
		mCallbacks.finishBroadcast();
		}
		}
		}

		public String getAddress() {
		mContext.enforceCallingOrSelfPermission(BLUETOOTH_PERM, "Need BLUETOOTH permission");
		@@ -1836,17 +1837,6 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
		mContext.getPackageName());
		}
		break;

		case MESSAGE_REGISTER_ADAPTER: {
		IBluetoothManagerCallback callback = (IBluetoothManagerCallback) msg.obj;
		mCallbacks.register(callback);
		break;
		}
		case MESSAGE_UNREGISTER_ADAPTER: {
		IBluetoothManagerCallback callback = (IBluetoothManagerCallback) msg.obj;
		mCallbacks.unregister(callback);
		break;
		}
		case MESSAGE_REGISTER_STATE_CHANGE_CALLBACK: {
		IBluetoothStateChangeCallback callback =
		(IBluetoothStateChangeCallback) msg.obj;