From a3531ba579cbab8d103fa0db8e1b197ef031c103 Mon Sep 17 00:00:00 2001 From: Rashed Abdel-Tawab Date: Sun, 30 Nov 2014 00:17:03 -0500 Subject: [PATCH] Status bar: Add HSPA+ icons Forward port H+ icon in the status bar when connected to HSPA+ Uses new vector drawables by @blunden PS1: Initial commit PS2: New vectors (thanks @blunden) PS3: Cleanup PS4: Use correct indentation (oops) PS5: Show correct icon in status bar (thanks @mikeNG) PS6: Remove leftover Holo icons (thanks @mikeNG) PS7: Rebase to depend on Holo icon removal (thanks @mikeNG) PS8: Update commit message Change-Id: Ia745c524d5e2530f50f12f961ea8533a4c8f5842 --- .../SystemUI/res/drawable/ic_qs_signal_hp.xml | 27 +++++++++++++ .../stat_sys_data_fully_connected_hp.xml | 27 +++++++++++++ packages/SystemUI/res/values/arrays.xml | 2 +- .../statusbar/policy/TelephonyIcons.java | 40 +++++++++++-------- 4 files changed, 79 insertions(+), 17 deletions(-) create mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_hp.xml create mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_hp.xml diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_hp.xml b/packages/SystemUI/res/drawable/ic_qs_signal_hp.xml new file mode 100644 index 000000000000..0b2b1156a91a --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_qs_signal_hp.xml @@ -0,0 +1,27 @@ + + + + + diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_hp.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_hp.xml new file mode 100644 index 000000000000..33596da31ad0 --- /dev/null +++ b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_hp.xml @@ -0,0 +1,27 @@ + + + + + diff --git a/packages/SystemUI/res/values/arrays.xml b/packages/SystemUI/res/values/arrays.xml index aaa21b93594f..652ff8b00b87 100644 --- a/packages/SystemUI/res/values/arrays.xml +++ b/packages/SystemUI/res/values/arrays.xml @@ -82,7 +82,7 @@ drawable/stat_sys_data_fully_connected_3g - drawable/stat_sys_data_fully_connected_h + drawable/stat_sys_data_fully_connected_hp drawable/stat_sys_data_fully_connected_g diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/policy/TelephonyIcons.java b/packages/SystemUI/src/com/android/systemui/statusbar/policy/TelephonyIcons.java index 5ec6be84b351..a90ea9692906 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/policy/TelephonyIcons.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/policy/TelephonyIcons.java @@ -144,6 +144,24 @@ class TelephonyIcons { R.drawable.ic_qs_signal_h }; + //HSPA+ + static final int[][] DATA_HP = { + { R.drawable.stat_sys_data_fully_connected_hp, + R.drawable.stat_sys_data_fully_connected_hp, + R.drawable.stat_sys_data_fully_connected_hp, + R.drawable.stat_sys_data_fully_connected_hp }, + { R.drawable.stat_sys_data_fully_connected_hp, + R.drawable.stat_sys_data_fully_connected_hp, + R.drawable.stat_sys_data_fully_connected_hp, + R.drawable.stat_sys_data_fully_connected_hp } + }; + + static final int[] QS_DATA_HP = { + R.drawable.ic_qs_signal_hp, + R.drawable.ic_qs_signal_hp + + }; + //CDMA // Use 3G icons for EVDO data and 1x icons for 1XRTT data static final int[][] DATA_1X = { @@ -409,22 +427,12 @@ class TelephonyIcons { } break; case TelephonyManager.NETWORK_TYPE_HSPAP: - if (hspaDistinguishable) { - mSelectedDataActivityIndex[sub] = DATA_TYPE_HP; - mSelectedDataTypeIcon[sub] = mRes.getIdentifier( - dataTypeArray[type], null, NS); - mSelectedQSDataTypeIcon[sub] = QS_DATA_H[inetCondition]; - mSelectedDataTypeDesc = mDataTypeDescriptionArray[type]; - mSelectedSignalStreagthIndex[sub] = SIGNAL_STRENGTH_TYPE_HP; - } else { - mSelectedDataActivityIndex[sub] = DATA_TYPE_3G; - mSelectedDataTypeIcon[sub] = mRes.getIdentifier( - mDataTypeGenerationArray[0], null, NS); - mSelectedQSDataTypeIcon[sub] = QS_DATA_3G[inetCondition]; - mSelectedDataTypeDesc = mDataTypeGenerationDescArray[0]; - mSelectedSignalStreagthIndex[sub] = SIGNAL_STRENGTH_TYPE_3G; - - } + mSelectedDataActivityIndex[sub] = DATA_TYPE_HP; + mSelectedDataTypeIcon[sub] = mRes.getIdentifier( + dataTypeArray[type], null, NS); + mSelectedQSDataTypeIcon[sub] = QS_DATA_HP[inetCondition]; + mSelectedDataTypeDesc = mDataTypeDescriptionArray[type]; + mSelectedSignalStreagthIndex[sub] = SIGNAL_STRENGTH_TYPE_HP; break; case TelephonyManager.NETWORK_TYPE_CDMA: if (!showAtLeast3G) { -- GitLab