Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2ac9c49 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

Remove incorrect/misleading irrelevancies from example code. 

(I'll start checking in all my benchmarks -- not just the ones relevant to this
document -- somewhere under dalvik/libcore/ tomorrow, and we can see about
linking to them for those who want something they can actually run, or just
want to see the exact code that was benchmarked.)
parent 27eb2414

docs/html/guide/practices/design/performance.jd

+7 −13
Original line number Diff line number Diff line
@@ -356,25 +356,19 @@ for loop syntax will be exactly equivalent to explicit iterator usage.</p> 


<p>There are several alternatives for iterating through an array:</p>



<pre>public class Foo {

<pre>    static class Foo {

        int mSplat;

    }

public class ArrayBenchmark {

    Foo[] mArray = new Foo[27];

    {

        for (int i = 0; i &lt; mArray.length; ++i) {

            mArray[i] = new Foo();

        }

    }

    Foo[] mArray = ...



    public static void zero() {

    public void zero() {

        int sum = 0;

        for (int i = 0; i &lt; mArray.length; ++i) {

            sum += mArray[i].mSplat;

        }

    }



    public static void one() {

    public void one() {

        int sum = 0;

        Foo[] localArray = mArray;

        int len = localArray.length;
@@ -384,13 +378,13 @@ public class ArrayBenchmark { 
        }

    }



    public static void two() {

    public void two() {

        int sum = 0;

        for (Foo a : mArray) {

            sum += a.mSplat;

        }

    }

}</pre>

</pre>



<p><strong>zero()</strong> is slowest, because the JIT can't yet optimize away

the cost of getting the array length once for every iteration through the