Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a246fa8e authored by Gustav Sennton's avatar Gustav Sennton
Browse files

Desktop tracing: log number-of-tasks once instead of once per task 

Save a few milliseconds of each relevant
DesktopModeLoggerTransitionObserver#onTransitionReady() call by only
updating the visible-tasks-counter once instead of once per task update.

Bug: 431922211
Flag: EXEMPT bugfix for tracing logic
Test: perfetto

Change-Id: I7b4b4849b1e9c07d3c18de0145897e909cd1566d
parent a6188aac

libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeLoggerTransitionObserver.kt

+13 −18
Original line number Original line Diff line number Diff line
@@ -359,16 +359,8 @@ class DesktopModeLoggerTransitionObserver( 
                    desktopModeEventLogger.logTaskAdded(

                    desktopModeEventLogger.logTaskAdded(

                        currentTaskUpdate.copy(unminimizeReason = unminimizeReason)

                        currentTaskUpdate.copy(unminimizeReason = unminimizeReason)

                    )

                    )

                    Trace.setCounter(

                        Trace.TRACE_TAG_WINDOW_MANAGER,

                        VISIBLE_TASKS_COUNTER_NAME,

                        postTransitionVisibleFreeformTasks.size.toLong(),

                    )

                    SystemProperties.set(

                        VISIBLE_TASKS_COUNTER_SYSTEM_PROPERTY,

                        postTransitionVisibleFreeformTasks.size.toString(),

                    )

                }

                }



                focusChangedReason != null ->

                focusChangedReason != null ->

                    desktopModeEventLogger.logTaskInfoChanged(currentTaskUpdate)

                    desktopModeEventLogger.logTaskInfoChanged(currentTaskUpdate)

                // old tasks that were resized or repositioned

                // old tasks that were resized or repositioned
@@ -395,6 +387,10 @@ class DesktopModeLoggerTransitionObserver( 
                        minimizeReason,

                        minimizeReason,

                    )

                    )

                desktopModeEventLogger.logTaskRemoved(taskUpdate)

                desktopModeEventLogger.logTaskRemoved(taskUpdate)

            }

        }



        if (preTransitionVisibleFreeformTasks.size != postTransitionVisibleFreeformTasks.size) {

            Trace.setCounter(

            Trace.setCounter(

                Trace.TRACE_TAG_WINDOW_MANAGER,

                Trace.TRACE_TAG_WINDOW_MANAGER,

                VISIBLE_TASKS_COUNTER_NAME,

                VISIBLE_TASKS_COUNTER_NAME,
@@ -406,7 +402,6 @@ class DesktopModeLoggerTransitionObserver( 
            )

            )

        }

        }

    }

    }

    }





    private fun getMinimizeReason(

    private fun getMinimizeReason(

        transition: IBinder?,

        transition: IBinder?,