Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1e24360 authored by tom hsu's avatar tom hsu
Browse files

[Bluetooth] Avoid crash from emtpy devcie name. 

Bug: 288233931
Test: atest passed
Change-Id: I85be66e6b985edcf1b02c55cc33236f9347846cf
parent a56a9d9a

packages/SettingsLib/src/com/android/settingslib/bluetooth/CachedBluetoothDevice.java

+1 −1
Original line number Diff line number Diff line
@@ -583,7 +583,7 @@ public class CachedBluetoothDevice implements Comparable<CachedBluetoothDevice> 
     */

    public void setName(String name) {

        // Prevent getName() to be set to null if setName(null) is called

        if (name == null || TextUtils.equals(name, getName())) {

        if (TextUtils.isEmpty(name) || TextUtils.equals(name, getName())) {

            return;

        }

        mDevice.setAlias(name);

packages/SettingsLib/tests/robotests/src/com/android/settingslib/bluetooth/CachedBluetoothDeviceTest.java

+7 −0
Original line number Diff line number Diff line
@@ -1014,6 +1014,13 @@ public class CachedBluetoothDeviceTest { 
        verify(mDevice, never()).setAlias(any());

    }



    @Test

    public void setName_setDeviceNameIsEmpty() {

        mCachedDevice.setName("");



        verify(mDevice, never()).setAlias(any());

    }



    @Test

    public void getProfileConnectionState_nullProfile_returnDisconnected() {

        assertThat(mCachedDevice.getProfileConnectionState(null)).isEqualTo(