Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1c1f2e2 authored by Songchun Fan's avatar Songchun Fan
Browse files

[pm] do not stop system apps with disabled a launcher activity 

If an app has a disabled/unexported launcher activity, it is effectively
the same as not having a launcher activity. We should not stop such
system apps by default.

BUG: 286459841
Test: manual with a system app that has disabled launcher activity and
verify that it is in the `stopped=false` state after first boot
Test: also tested updating such a system app and verified that it
remains in the un-stopped state after the update is uninstalled

Change-Id: Ie865aba7325e3442c6610ef962fce3a3a65f0b70
parent c3415b9f

services/core/java/com/android/server/pm/InstallPackageHelper.java

+7 −2
Original line number Diff line number Diff line
@@ -4315,7 +4315,8 @@ final class InstallPackageHelper { 
        //   - It's an APEX or overlay package since stopped state does not affect them.

        //   - It is enumerated with a <initial-package-state> tag having the stopped attribute

        //     set to false

        //   - It doesn't have a launcher entry which means the user doesn't have a way to unstop it

        //   - It doesn't have an enabled and exported launcher activity, which means the user

        //     wouldn't have a way to un-stop it

        final boolean isApexPkg = (scanFlags & SCAN_AS_APEX) != 0;

        if (mPm.mShouldStopSystemPackagesByDefault

                && scanSystemPartition
@@ -4341,7 +4342,11 @@ final class InstallPackageHelper { 
        categories.add(Intent.CATEGORY_LAUNCHER);

        final List<ParsedActivity> activities = parsedPackage.getActivities();

        for (int indexActivity = 0; indexActivity < activities.size(); indexActivity++) {

            final List<ParsedIntentInfo> intents = activities.get(indexActivity).getIntents();

            final ParsedActivity activity = activities.get(indexActivity);

            if (!activity.isEnabled() || !activity.isExported()) {

                continue;

            }

            final List<ParsedIntentInfo> intents = activity.getIntents();

            for (int indexIntent = 0; indexIntent < intents.size(); indexIntent++) {

                final IntentFilter intentFilter = intents.get(indexIntent).getIntentFilter();

                if (intentFilter != null && intentFilter.matchCategories(categories) == null) {