Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1963a9b authored by Janis Danisevskis's avatar Janis Danisevskis
Browse files

Keystore 2.0: Fix diagnosing invalid key in CipherSpiBase. 

Bug: 183101158
Test: atest CtsLibcoreTestCases:com.android.org.conscrypt.javax.crypto.CipherBasicsTest#testAeadEncryption

Change-Id: Idc9c7dc2614a47818227a06fe76078f72c0c1f57
parent df786ca1

keystore/java/android/security/keystore2/AndroidKeyStoreCipherSpiBase.java

+9 −6
Original line number Diff line number Diff line
@@ -123,8 +123,9 @@ abstract class AndroidKeyStoreCipherSpiBase extends CipherSpi implements KeyStor 
            throws InvalidKeyException {

        resetAll();



        if (!(key instanceof AndroidKeyStorePrivateKey

                || key instanceof AndroidKeyStoreSecretKey)) {

        // Public key operations get diverted to the default provider.

        if (opmode == Cipher.ENCRYPT_MODE

                && (key instanceof PrivateKey || key instanceof PublicKey)) {

            try {

                mCipher = Cipher.getInstance(getTransform());

                String transform = getTransform();
@@ -184,8 +185,9 @@ abstract class AndroidKeyStoreCipherSpiBase extends CipherSpi implements KeyStor 
            SecureRandom random) throws InvalidKeyException, InvalidAlgorithmParameterException {

        resetAll();



        if (!(key instanceof AndroidKeyStorePrivateKey

                || key instanceof AndroidKeyStoreSecretKey)) {

        // Public key operations get diverted to the default provider.

        if (opmode == Cipher.ENCRYPT_MODE

                && (key instanceof PrivateKey || key instanceof PublicKey)) {

            try {

                mCipher = Cipher.getInstance(getTransform());

                mCipher.init(opmode, key, params, random);
@@ -213,8 +215,9 @@ abstract class AndroidKeyStoreCipherSpiBase extends CipherSpi implements KeyStor 
            SecureRandom random) throws InvalidKeyException, InvalidAlgorithmParameterException {

        resetAll();



        if (!(key instanceof AndroidKeyStorePrivateKey

                || key instanceof AndroidKeyStoreSecretKey)) {

        // Public key operations get diverted to the default provider.

        if (opmode == Cipher.ENCRYPT_MODE

                && (key instanceof PrivateKey || key instanceof PublicKey)) {

            try {

                mCipher = Cipher.getInstance(getTransform());

                mCipher.init(opmode, key, params, random);