Merge "Add logging for BAL" into rvc-dev (a1951e19) · Commits · e / os / android_frameworks_base

services/core/java/com/android/server/wm/ActivityStarter.java

+56 −0

Original line number	Diff line number	Diff line
		@@ -61,6 +61,7 @@ import static com.android.server.wm.ActivityStackSupervisor.DEFER_RESUME;
		import static com.android.server.wm.ActivityStackSupervisor.ON_TOP;
		import static com.android.server.wm.ActivityStackSupervisor.PRESERVE_WINDOWS;
		import static com.android.server.wm.ActivityStackSupervisor.TAG_TASKS;
		import static com.android.server.wm.ActivityTaskManagerDebugConfig.DEBUG_ACTIVITY_STARTS;
		import static com.android.server.wm.ActivityTaskManagerDebugConfig.DEBUG_CONFIGURATION;
		import static com.android.server.wm.ActivityTaskManagerDebugConfig.DEBUG_PERMISSIONS_REVIEW;
		import static com.android.server.wm.ActivityTaskManagerDebugConfig.DEBUG_RESULTS;
		@@ -108,6 +109,7 @@ import android.os.UserManager;
		import android.service.voice.IVoiceInteractionSession;
		import android.text.TextUtils;
		import android.util.ArraySet;
		import android.util.DebugUtils;
		import android.util.Pools.SynchronizedPool;
		import android.util.Slog;

		@@ -1195,6 +1197,9 @@ class ActivityStarter {
		final int callingAppId = UserHandle.getAppId(callingUid);
		if (callingUid == Process.ROOT_UID \|\| callingAppId == Process.SYSTEM_UID
		\|\| callingAppId == Process.NFC_UID) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "Activity start allowed for important callingUid (" + callingUid + ")");
		}
		return false;
		}

		@@ -1208,6 +1213,11 @@ class ActivityStarter {
		final boolean isCallingUidPersistentSystemProcess =
		callingUidProcState <= ActivityManager.PROCESS_STATE_PERSISTENT_UI;
		if (callingUidHasAnyVisibleWindow \|\| isCallingUidPersistentSystemProcess) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "Activity start allowed: callingUidHasAnyVisibleWindow = " + callingUid
		+ ", isCallingUidPersistentSystemProcess = "
		+ isCallingUidPersistentSystemProcess);
		}
		return false;
		}
		// take realCallingUid into consideration
		@@ -1229,35 +1239,66 @@ class ActivityStarter {
		if (realCallingUid != callingUid) {
		// don't abort if the realCallingUid has a visible window
		if (realCallingUidHasAnyVisibleWindow) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "Activity start allowed: realCallingUid (" + realCallingUid
		+ ") has visible (non-toast) window");
		}
		return false;
		}
		// if the realCallingUid is a persistent system process, abort if the IntentSender
		// wasn't whitelisted to start an activity
		if (isRealCallingUidPersistentSystemProcess && allowBackgroundActivityStart) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "Activity start allowed: realCallingUid (" + realCallingUid
		+ ") is persistent system process AND intent sender whitelisted "
		+ "(allowBackgroundActivityStart = true)");
		}
		return false;
		}
		// don't abort if the realCallingUid is an associated companion app
		if (mService.isAssociatedCompanionApp(UserHandle.getUserId(realCallingUid),
		realCallingUid)) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "Activity start allowed: realCallingUid (" + realCallingUid
		+ ") is companion app");
		}
		return false;
		}
		}
		// don't abort if the callingUid has START_ACTIVITIES_FROM_BACKGROUND permission
		if (mService.checkPermission(START_ACTIVITIES_FROM_BACKGROUND, callingPid, callingUid)
		== PERMISSION_GRANTED) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG,
		"Background activity start allowed: START_ACTIVITIES_FROM_BACKGROUND "
		+ "permission granted for uid "
		+ callingUid);
		}
		return false;
		}
		// don't abort if the caller has the same uid as the recents component
		if (mSupervisor.mRecentTasks.isCallerRecents(callingUid)) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "Background activity start allowed: callingUid (" + callingUid
		+ ") is recents");
		}
		return false;
		}
		// don't abort if the callingUid is the device owner
		if (mService.isDeviceOwner(callingUid)) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "Background activity start allowed: callingUid (" + callingUid
		+ ") is device owner");
		}
		return false;
		}
		// don't abort if the callingUid has companion device
		final int callingUserId = UserHandle.getUserId(callingUid);
		if (mService.isAssociatedCompanionApp(callingUserId, callingUid)) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "Background activity start allowed: callingUid (" + callingUid
		+ ") is companion app");
		}
		return false;
		}
		// If we don't have callerApp at this point, no caller was provided to startActivity().
		@@ -1273,6 +1314,10 @@ class ActivityStarter {
		if (callerApp != null) {
		// first check the original calling process
		if (callerApp.areBackgroundActivityStartsAllowed()) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "Background activity start allowed: callerApp process (pid = "
		+ callerApp.getPid() + ", uid = " + callerAppUid + ") is whitelisted");
		}
		return false;
		}
		// only if that one wasn't whitelisted, check the other ones
		@@ -1282,6 +1327,11 @@ class ActivityStarter {
		for (int i = uidProcesses.size() - 1; i >= 0; i--) {
		final WindowProcessController proc = uidProcesses.valueAt(i);
		if (proc != callerApp && proc.areBackgroundActivityStartsAllowed()) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG,
		"Background activity start allowed: process " + proc.getPid()
		+ " from uid " + callerAppUid + " is whitelisted");
		}
		return false;
		}
		}
		@@ -1297,9 +1347,15 @@ class ActivityStarter {
		Slog.w(TAG, "Background activity start [callingPackage: " + callingPackage
		+ "; callingUid: " + callingUid
		+ "; isCallingUidForeground: " + isCallingUidForeground
		+ "; callingUidHasAnyVisibleWindow: " + callingUidHasAnyVisibleWindow
		+ "; callingUidProcState: " + DebugUtils.valueToString(ActivityManager.class,
		"PROCESS_STATE_", callingUidProcState)
		+ "; isCallingUidPersistentSystemProcess: " + isCallingUidPersistentSystemProcess
		+ "; realCallingUid: " + realCallingUid
		+ "; isRealCallingUidForeground: " + isRealCallingUidForeground
		+ "; realCallingUidHasAnyVisibleWindow: " + realCallingUidHasAnyVisibleWindow
		+ "; realCallingUidProcState: " + DebugUtils.valueToString(ActivityManager.class,
		"PROCESS_STATE_", realCallingUidProcState)
		+ "; isRealCallingUidPersistentSystemProcess: "
		+ isRealCallingUidPersistentSystemProcess
		+ "; originatingPendingIntent: " + originatingPendingIntent

services/core/java/com/android/server/wm/ActivityTaskManagerDebugConfig.java

+1 −0

Original line number	Diff line number	Diff line
		@@ -65,6 +65,7 @@ public class ActivityTaskManagerDebugConfig {
		static final boolean DEBUG_USER_LEAVING = DEBUG_ALL \|\| false;
		static final boolean DEBUG_PERMISSIONS_REVIEW = DEBUG_ALL \|\| false;
		static final boolean DEBUG_RESULTS = DEBUG_ALL \|\| false;
		static final boolean DEBUG_ACTIVITY_STARTS = DEBUG_ALL \|\| false;
		public static final boolean DEBUG_CLEANUP = DEBUG_ALL \|\| false;
		public static final boolean DEBUG_METRICS = DEBUG_ALL \|\| false;

services/core/java/com/android/server/wm/WindowProcessController.java

+34 −0

Original line number	Diff line number	Diff line
		@@ -29,6 +29,7 @@ import static com.android.server.wm.ActivityStack.ActivityState.PAUSING;
		import static com.android.server.wm.ActivityStack.ActivityState.RESUMED;
		import static com.android.server.wm.ActivityStack.ActivityState.STARTED;
		import static com.android.server.wm.ActivityStack.ActivityState.STOPPING;
		import static com.android.server.wm.ActivityTaskManagerDebugConfig.DEBUG_ACTIVITY_STARTS;
		import static com.android.server.wm.ActivityTaskManagerDebugConfig.DEBUG_CONFIGURATION;
		import static com.android.server.wm.ActivityTaskManagerDebugConfig.DEBUG_RELEASE;
		import static com.android.server.wm.ActivityTaskManagerDebugConfig.POSTFIX_CONFIGURATION;
		@@ -430,6 +431,11 @@ public class WindowProcessController extends ConfigurationContainer<Configuratio

		void setLastActivityLaunchTime(long launchTime) {
		if (launchTime <= mLastActivityLaunchTime) {
		if (launchTime < mLastActivityLaunchTime) {
		Slog.w(TAG,
		"Tried to set launchTime (" + launchTime + ") < mLastActivityLaunchTime ("
		+ mLastActivityLaunchTime + ")");
		}
		return;
		}
		mLastActivityLaunchTime = launchTime;
		@@ -449,6 +455,10 @@ public class WindowProcessController extends ConfigurationContainer<Configuratio
		boolean areBackgroundActivityStartsAllowed() {
		// allow if the whitelisting flag was explicitly set
		if (mAllowBackgroundActivityStarts) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "[WindowProcessController(" + mPid
		+ ")] Activity start allowed: mAllowBackgroundActivityStarts = true");
		}
		return true;
		}
		// allow if any activity in the caller has either started or finished very recently, and
		@@ -460,19 +470,43 @@ public class WindowProcessController extends ConfigurationContainer<Configuratio
		// let app to be able to start background activity even it's in grace period.
		if (mLastActivityLaunchTime > mAtm.getLastStopAppSwitchesTime()
		\|\| mLastActivityFinishTime > mAtm.getLastStopAppSwitchesTime()) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "[WindowProcessController(" + mPid
		+ ")] Activity start allowed: within "
		+ ACTIVITY_BG_START_GRACE_PERIOD_MS + "ms grace period");
		}
		return true;
		}
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "[WindowProcessController(" + mPid + ")] Activity start within "
		+ ACTIVITY_BG_START_GRACE_PERIOD_MS
		+ "ms grace period but also within stop app switch window");
		}

		}
		// allow if the proc is instrumenting with background activity starts privs
		if (mInstrumentingWithBackgroundActivityStartPrivileges) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "[WindowProcessController(" + mPid
		+ ")] Activity start allowed: process instrumenting with background "
		+ "activity starts privileges");
		}
		return true;
		}
		// allow if the caller has an activity in any foreground task
		if (hasActivityInVisibleTask()) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "[WindowProcessController(" + mPid
		+ ")] Activity start allowed: process has activity in foreground task");
		}
		return true;
		}
		// allow if the caller is bound by a UID that's currently foreground
		if (isBoundByForegroundUid()) {
		if (DEBUG_ACTIVITY_STARTS) {
		Slog.d(TAG, "[WindowProcessController(" + mPid
		+ ")] Activity start allowed: process bound by foreground uid");
		}
		return true;
		}
		return false;

Original line number	Diff line number	Diff line
		@@ -65,6 +65,7 @@ public class ActivityTaskManagerDebugConfig {
		static final boolean DEBUG_USER_LEAVING = DEBUG_ALL \|\| false;
		static final boolean DEBUG_PERMISSIONS_REVIEW = DEBUG_ALL \|\| false;
		static final boolean DEBUG_RESULTS = DEBUG_ALL \|\| false;
		static final boolean DEBUG_ACTIVITY_STARTS = DEBUG_ALL \|\| false;
		public static final boolean DEBUG_CLEANUP = DEBUG_ALL \|\| false;
		public static final boolean DEBUG_METRICS = DEBUG_ALL \|\| false;