Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a163bdcf authored by Bjorn Bringert's avatar Bjorn Bringert
Browse files

Don't enforce that search dialog is a singleton. 

There was code in PhoneWindowManager from last time when
the search dialog was a system dialog that caused an exception
if the search was added to the window manager twice.
Generally there should only be one search bar, but because
window manager calls are asynchronous and don't execute in order,
we can't be sure that a call to stopSearch() has removed the search
dialog before a subsequent call to startSearch() tries to add it again.

SearchManagerTest.testSearchManagerFastInvocations() crashed the system
process before this change.
parent 5cb8d79f

policy/com/android/internal/policy/impl/PhoneWindowManager.java

+0 −11
Original line number Diff line number Diff line
@@ -160,7 +160,6 @@ public class PhoneWindowManager implements WindowManagerPolicy { 
    

    boolean mSafeMode;

    WindowState mStatusBar = null;

    WindowState mSearchBar = null;

    WindowState mKeyguard = null;

    KeyguardViewMediator mKeyguardMediator;

    GlobalActions mGlobalActions;
@@ -702,7 +701,6 @@ public class PhoneWindowManager implements WindowManagerPolicy { 
     * Currently enforces that three window types are singletons:

     * <ul>

     * <li>STATUS_BAR_TYPE</li>

     * <li>SEARCH_BAR_TYPE</li>

     * <li>KEYGUARD_TYPE</li>

     * </ul>

     *
@@ -719,12 +717,6 @@ public class PhoneWindowManager implements WindowManagerPolicy { 
                }

                mStatusBar = win;

                break;

            case TYPE_SEARCH_BAR:

                if (mSearchBar != null) {

                    return WindowManagerImpl.ADD_MULTIPLE_SINGLETON;

                }

                mSearchBar = win;

                break;

            case TYPE_KEYGUARD:

                if (mKeyguard != null) {

                    return WindowManagerImpl.ADD_MULTIPLE_SINGLETON;
@@ -740,9 +732,6 @@ public class PhoneWindowManager implements WindowManagerPolicy { 
        if (mStatusBar == win) {

            mStatusBar = null;

        }

        else if (mSearchBar == win) {

            mSearchBar = null;

        }

        else if (mKeyguard == win) {

            mKeyguard = null;

        }