Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a159dafd authored by Ioana Alexandru's avatar Ioana Alexandru Committed by Android Build Coastguard Worker
Browse files

Don't attach pipeline to group expansion mgr. 

This is to avoid a bug where the group state is broken after a
notification is removed and then re-added (e.g. after being filtered by
zenmode), and ExpandableNotificationRow.areChildrenExpanded ends up out
of sync with ExpandableNotificationRow.isGroupExpanded.

Bug: 282865576
Test: tested manually that the bug doesn't happen anymore
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7f807071bebd48ff422b5eec09598685dd44e092)
Merged-In: Id3066a9269b9484a30f16bd43236b061b0b6aefe
Change-Id: Id3066a9269b9484a30f16bd43236b061b0b6aefe
parent 5625faf3

packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/StackCoordinator.kt

+4 −1
Original line number Diff line number Diff line
@@ -39,7 +39,10 @@ class StackCoordinator @Inject internal constructor( 


    override fun attach(pipeline: NotifPipeline) {

        pipeline.addOnAfterRenderListListener(::onAfterRenderList)

        groupExpansionManagerImpl.attach(pipeline)

        // TODO(b/282865576): This has an issue where it makes changes to some groups without

        // notifying listeners. To be fixed in QPR, but for now let's comment it out to avoid the

        // group expansion bug.

        // groupExpansionManagerImpl.attach(pipeline)

    }



    fun onAfterRenderList(entries: List<ListEntry>, controller: NotifStackController) =