Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a13ad431 authored by Ashwini Oruganti's avatar Ashwini Oruganti
Browse files

SyncManager: Mark unaudited PendingIntents with FLAG_MUTABLE_UNAUDITED 

These PIs need an explicit mutability flag. This temporay flag is being
used to mark these points in code and should be replaced ASAP.
See go/immutable-pendingintents for more context.

Bug: 160794467
Test: TH
Exempt-From-Owner-Approval: noop change
Change-Id: I3e2759285cf544c25a4f461f6cbdf62bc3f80932
parent 24e5b93c

services/core/java/com/android/server/content/SyncManager.java

+4 −1
Original line number Diff line number Diff line
@@ -3838,9 +3838,12 @@ public class SyncManager { 
            }



            UserHandle user = new UserHandle(userId);

            // TODO(b/174186839) Please replace FLAG_MUTABLE_UNAUDITED below

            // with either FLAG_IMMUTABLE (recommended) or FLAG_MUTABLE.

            final PendingIntent pendingIntent = PendingIntent

                    .getActivityAsUser(mContext, 0, clickIntent,

                            PendingIntent.FLAG_CANCEL_CURRENT, null, user);

                            PendingIntent.FLAG_CANCEL_CURRENT

                            | PendingIntent.FLAG_MUTABLE_UNAUDITED, null, user);



            CharSequence tooManyDeletesDescFormat = mContext.getResources().getText(

                    R.string.contentServiceTooManyDeletesNotificationDesc);