Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a136ebb7 authored by Evan Rosky's avatar Evan Rosky
Browse files

Pass NO_USER_ACTION activity option along to shell transition 

When this is set, it means that an app should not enter pip.
So, just make sure to communicate this to shell-transition
as well so it doesn't try to pip.

Bug: 231150295
Test: atest PinnedStackTests#testAutoPipOnLaunchingActivityWithNoUserAction
Change-Id: Id373716015d47cdaba0525fd9dea923f4b40303c
parent c6ce86e6

services/core/java/com/android/server/wm/ActivityStarter.java

+4 −0
Original line number Diff line number Diff line
@@ -1747,6 +1747,10 @@ class ActivityStarter { 
            // until after we launched to identify the relevant activity.

            transitionController.setTransientLaunch(mLastStartActivityRecord, mPriorAboveTask);

        }

        if (!mSupervisor.mUserLeaving) {

            // no-user-leaving implies not entering PiP.

            transitionController.setCanPipOnFinish(false /* canPipOnFinish */);

        }

        if (newTransition != null) {

            transitionController.requestStartTransition(newTransition,

                    mTargetTask == null ? started.getTask() : mTargetTask,

services/core/java/com/android/server/wm/TransitionController.java

+6 −0
Original line number Diff line number Diff line
@@ -544,6 +544,12 @@ class TransitionController { 
        }

    }



    /** @see Transition#setCanPipOnFinish */

    void setCanPipOnFinish(boolean canPipOnFinish) {

        if (mCollectingTransition == null) return;

        mCollectingTransition.setCanPipOnFinish(canPipOnFinish);

    }



    void legacyDetachNavigationBarFromApp(@NonNull IBinder token) {

        final Transition transition = Transition.fromBinder(token);

        if (transition == null || !mPlayingTransitions.contains(transition)) {