Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0b896e2 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Automerger Merge Worker
Browse files

Merge "[cleanup] Enable clang-tidy and fix warnings" into rvc-dev am: defa83d8 

Change-Id: Ib3b5376cc98a41084b1c4c85ac499e0818f90b7d
parents 8743ac64 defa83d8

services/incremental/Android.bp

+15 −0
Original line number Diff line number Diff line
@@ -19,6 +19,21 @@ cc_defaults { 
    proto: {

        type: "lite",

    },

    tidy: true,

    tidy_checks: [

        "android-*",

        "cert-*",

        "clang-analyzer-security*",

        "-cert-err34-c",

        "clang-analyzer-security*",

        // Disabling due to many unavoidable warnings from POSIX API usage.

        "-google-runtime-int",

        "-google-explicit-constructor",

        // do not define variadic C function - JNI headers

        "-cert-dcl50-cpp",

        // operator=() does not handle self-assignment properly - all protobuf-generated classes

        "-cert-oop54-cpp",

    ],

}



cc_defaults {

services/incremental/IncrementalService.cpp

+1 −1
Original line number Diff line number Diff line
@@ -1395,7 +1395,7 @@ bool IncrementalService::configureNativeBinaries(StorageId storage, std::string_ 
        auto startFileTs = Clock::now();



        const auto libName = path::basename(fileName);

        const auto targetLibPath = path::join(libDirRelativePath, libName);

        auto targetLibPath = path::join(libDirRelativePath, libName);

        const auto targetLibPathAbsolute = normalizePathToStorage(*ifs, storage, targetLibPath);

        // If the extract file already exists, skip

        if (access(targetLibPathAbsolute.c_str(), F_OK) == 0) {

services/incremental/ServiceWrappers.cpp

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ static constexpr auto kDataLoaderManagerName = "dataloader_manager"sv; 


class RealVoldService : public VoldServiceWrapper {

public:

    RealVoldService(const sp<os::IVold> vold) : mInterface(std::move(vold)) {}

    RealVoldService(sp<os::IVold> vold) : mInterface(std::move(vold)) {}

    ~RealVoldService() = default;

    binder::Status mountIncFs(

            const std::string& backingPath, const std::string& targetDir, int32_t flags,