Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a067bd42 authored by Matías Hernández's avatar Matías Hernández Committed by Android Build Coastguard Worker
Browse files

Grant URI permissions to the CallStyle-related ones 

This will also verify that the caller app can actually grant them.

Fix: 274592467
Test: atest NotificationManagerServiceTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4dee5aab12e95cd8b4d663ad050f07b0f2433596)
Merged-In: I83429f9e63e51c615a6e3f03befb76bb5b8ea7fc
Change-Id: I83429f9e63e51c615a6e3f03befb76bb5b8ea7fc
parent 0c4f9bd6

core/java/android/app/Notification.java

+8 −0
Original line number Diff line number Diff line
@@ -2883,6 +2883,14 @@ public class Notification implements Parcelable 
            }

        }













        if (isStyle(CallStyle.class) & extras != null) {













            Person callPerson = extras.getParcelable(EXTRA_CALL_PERSON);













            if (callPerson != null) {













                visitor.accept(callPerson.getIconUri());













            }













            visitIconUri(visitor, extras.getParcelable(EXTRA_VERIFICATION_ICON));













        }



























        if (mBubbleMetadata != null) {















            visitIconUri(visitor, mBubbleMetadata.getIcon());















        }

































services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java



+23
−0




























Original line number
Diff line number
Diff line








@@ -5390,6 +5390,29 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {













        verify(visitor, times(1)).accept(eq(backgroundImage));















    }





























    @Test













    public void testVisitUris_callStyle() {













        Icon personIcon = Icon.createWithContentUri("content://media/person");













        Icon verificationIcon = Icon.createWithContentUri("content://media/verification");













        Person callingPerson = new Person.Builder().setName("Someone")













                .setIcon(personIcon)













                .build();













        PendingIntent hangUpIntent = PendingIntent.getActivity(mContext, 0, new Intent(),













                PendingIntent.FLAG_IMMUTABLE);













        Notification n = new Notification.Builder(mContext, "a")













                .setStyle(Notification.CallStyle.forOngoingCall(callingPerson, hangUpIntent)













                        .setVerificationIcon(verificationIcon))













                .setContentTitle("Calling...")













                .setSmallIcon(android.R.drawable.sym_def_app_icon)













                .build();



























        Consumer<Uri> visitor = (Consumer<Uri>) spy(Consumer.class);













        n.visitUris(visitor);



























        verify(visitor, times(1)).accept(eq(personIcon.getUri()));













        verify(visitor, times(1)).accept(eq(verificationIcon.getUri()));













    }





























    @Test















    public void testVisitUris_audioContentsString() throws Exception {















        final Uri audioContents = Uri.parse("content://com.example/audio");