Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a05b30e6 authored by lijilou's avatar lijilou Committed by Jilou li
Browse files

JobConcurrencyManager: fix the NPE problem. 

 mRunningJob maybe null if there is no job running.

Test: OEM monkey test
Flag: EXEMPT bugfix
Bug: 381776408
Change-Id: I36284ba4afe28d6da57ee79a2d27d722928747ae
parent 2623db82

apex/jobscheduler/service/java/com/android/server/job/JobConcurrencyManager.java

+4 −3
Original line number Diff line number Diff line
@@ -1034,7 +1034,7 @@ class JobConcurrencyManager { 
                for (int p = preferredUidOnly.size() - 1; p >= 0; --p) {

                    final ContextAssignment assignment = preferredUidOnly.get(p);

                    final JobStatus runningJob = assignment.context.getRunningJobLocked();

                    if (runningJob.getUid() != nextPending.getUid()) {

                    if (runningJob == null || runningJob.getUid() != nextPending.getUid()) {

                        continue;

                    }

                    final int jobBias = mService.evaluateJobBiasLocked(runningJob);
@@ -1916,8 +1916,9 @@ class JobConcurrencyManager { 
        for (int i = 0; i < mActiveServices.size(); i++) {

            final JobServiceContext jc = mActiveServices.get(i);

            final JobStatus js = jc.getRunningJobLocked();

            if (jc.stopIfExecutingLocked(pkgName, userId, namespace, matchJobId, jobId,

                    stopReason, internalStopReason)) {

            if (js != null &&

                    jc.stopIfExecutingLocked(pkgName, userId, namespace,

                        matchJobId, jobId, stopReason, internalStopReason)) {

                foundSome = true;

                pw.print("Stopping job: ");

                js.printUniqueId(pw);