Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a04e44c8 authored by Nataniel Borges's avatar Nataniel Borges
Browse files

Demote failing flame presubmit tests 

Bug: 247464794
Bug: 241525302
Bug: 241524174
Bug: 249308003
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I61d24e5d1c5162cd4755b807725c4bda6ce7b718
parent 12421fe9

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/ExpandPipOnDoubleClickTest.kt

+74 −9
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ 
package com.android.wm.shell.flicker.pip



import android.platform.test.annotations.FlakyTest

import android.platform.test.annotations.Presubmit

import android.view.Surface

import androidx.test.filters.RequiresDevice

import com.android.server.wm.flicker.FlickerParametersRunnerFactory
@@ -66,7 +65,7 @@ class ExpandPipOnDoubleClickTest(testSpec: FlickerTestParameter) : PipTransition 
     * Checks that the pip app window remains inside the display bounds throughout the whole

     * animation

     */

    @Presubmit

    @FlakyTest(bugId = 249308003)

    @Test

    fun pipWindowRemainInsideVisibleBounds() {

        testSpec.assertWmVisibleRegion(pipApp) {
@@ -78,7 +77,7 @@ class ExpandPipOnDoubleClickTest(testSpec: FlickerTestParameter) : PipTransition 
     * Checks that the pip app layer remains inside the display bounds throughout the whole

     * animation

     */

    @Presubmit

    @FlakyTest(bugId = 249308003)

    @Test

    fun pipLayerRemainInsideVisibleBounds() {

        testSpec.assertLayersVisibleRegion(pipApp) {
@@ -89,7 +88,7 @@ class ExpandPipOnDoubleClickTest(testSpec: FlickerTestParameter) : PipTransition 
    /**

     * Checks [pipApp] window remains visible throughout the animation

     */

    @Presubmit

    @FlakyTest(bugId = 249308003)

    @Test

    fun pipWindowIsAlwaysVisible() {

        testSpec.assertWm {
@@ -100,7 +99,7 @@ class ExpandPipOnDoubleClickTest(testSpec: FlickerTestParameter) : PipTransition 
    /**

     * Checks [pipApp] layer remains visible throughout the animation

     */

    @Presubmit

    @FlakyTest(bugId = 249308003)

    @Test

    fun pipLayerIsAlwaysVisible() {

        testSpec.assertLayers {
@@ -111,7 +110,7 @@ class ExpandPipOnDoubleClickTest(testSpec: FlickerTestParameter) : PipTransition 
    /**

     * Checks that the visible region of [pipApp] always expands during the animation

     */

    @Presubmit

    @FlakyTest(bugId = 249308003)

    @Test

    fun pipLayerExpands() {

        testSpec.assertLayers {
@@ -122,7 +121,7 @@ class ExpandPipOnDoubleClickTest(testSpec: FlickerTestParameter) : PipTransition 
        }

    }



    @Presubmit

    @FlakyTest(bugId = 249308003)

    @Test

    fun pipSameAspectRatio() {

        testSpec.assertLayers {
@@ -136,7 +135,7 @@ class ExpandPipOnDoubleClickTest(testSpec: FlickerTestParameter) : PipTransition 
    /**

     * Checks [pipApp] window remains pinned throughout the animation

     */

    @Presubmit

    @FlakyTest(bugId = 249308003)

    @Test

    fun windowIsAlwaysPinned() {

        testSpec.assertWm {
@@ -147,7 +146,7 @@ class ExpandPipOnDoubleClickTest(testSpec: FlickerTestParameter) : PipTransition 
    /**

     * Checks [ComponentMatcher.LAUNCHER] layer remains visible throughout the animation

     */

    @Presubmit

    @FlakyTest(bugId = 249308003)

    @Test

    fun launcherIsAlwaysVisible() {

        testSpec.assertLayers {
@@ -166,6 +165,72 @@ class ExpandPipOnDoubleClickTest(testSpec: FlickerTestParameter) : PipTransition 
        }

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun navBarLayerIsVisibleAtStartAndEnd() {

        super.navBarLayerIsVisibleAtStartAndEnd()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun navBarWindowIsAlwaysVisible() {

        super.navBarWindowIsAlwaysVisible()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun statusBarLayerIsVisibleAtStartAndEnd() {

        super.statusBarLayerIsVisibleAtStartAndEnd()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun statusBarLayerPositionAtStartAndEnd() {

        super.statusBarLayerPositionAtStartAndEnd()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun taskBarLayerIsVisibleAtStartAndEnd() {

        super.taskBarLayerIsVisibleAtStartAndEnd()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun taskBarWindowIsAlwaysVisible() {

        super.taskBarWindowIsAlwaysVisible()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun visibleLayersShownMoreThanOneConsecutiveEntry() {

        super.visibleLayersShownMoreThanOneConsecutiveEntry()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun statusBarWindowIsAlwaysVisible() {

        super.statusBarWindowIsAlwaysVisible()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun visibleWindowsShownMoreThanOneConsecutiveEntry() {

        super.visibleWindowsShownMoreThanOneConsecutiveEntry()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun entireScreenCovered() {

        super.entireScreenCovered()

    }



    @FlakyTest(bugId = 216306753)

    @Test

    override fun navBarLayerPositionAtStartAndEnd() {

        super.navBarLayerPositionAtStartAndEnd()

    }



    companion object {

        /**

         * Creates the test configurations.

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/splitscreen/DismissSplitScreenByGoHome.kt

+12 −5
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ class DismissSplitScreenByGoHome( 
    @Test

    fun splitScreenDividerBecomesInvisible() = testSpec.splitScreenDividerBecomesInvisible()



    @Presubmit

    @FlakyTest(bugId = 241525302)

    @Test

    fun primaryAppLayerBecomesInvisible() = testSpec.layerBecomesInvisible(primaryApp)
@@ -87,12 +87,18 @@ class DismissSplitScreenByGoHome( 
    @FlakyTest(bugId = 245472831)

    @Test

    fun primaryAppBoundsBecomesInvisible() = testSpec.splitAppLayerBoundsBecomesInvisible(

        primaryApp, landscapePosLeft = tapl.isTablet, portraitPosTop = false)

        primaryApp,

        landscapePosLeft = tapl.isTablet,

        portraitPosTop = false

    )



    @Presubmit

    @FlakyTest(bugId = 241525302)

    @Test

    fun secondaryAppBoundsBecomesInvisible() = testSpec.splitAppLayerBoundsBecomesInvisible(

        secondaryApp, landscapePosLeft = !tapl.isTablet, portraitPosTop = true)

        secondaryApp,

        landscapePosLeft = !tapl.isTablet,

        portraitPosTop = true

    )



    @Presubmit

    @Test
@@ -175,7 +181,8 @@ class DismissSplitScreenByGoHome( 
            return FlickerTestParameterFactory.getInstance().getConfigNonRotationTests(

                // TODO(b/176061063):The 3 buttons of nav bar do not exist in the hierarchy.

                supportedNavigationModes =

                    listOf(WindowManagerPolicyConstants.NAV_BAR_MODE_GESTURAL_OVERLAY))

                listOf(WindowManagerPolicyConstants.NAV_BAR_MODE_GESTURAL_OVERLAY)

            )

        }

    }

}

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/splitscreen/SwitchAppByDoubleTapDivider.kt

+18 −11
Original line number Diff line number Diff line
@@ -127,35 +127,41 @@ class SwitchAppByDoubleTapDivider(testSpec: FlickerTestParameter) : SplitScreenB 
        // robust enough to get the correct end state.

    }



    @Presubmit

    @FlakyTest(bugId = 241524174)

    @Test

    fun splitScreenDividerKeepVisible() = testSpec.layerKeepVisible(SPLIT_SCREEN_DIVIDER_COMPONENT)



    @Presubmit

    @FlakyTest(bugId = 241524174)

    @Test

    fun primaryAppLayerIsVisibleAtEnd() = testSpec.layerIsVisibleAtEnd(primaryApp)



    @Presubmit

    @FlakyTest(bugId = 241524174)

    @Test

    fun secondaryAppLayerIsVisibleAtEnd() = testSpec.layerIsVisibleAtEnd(secondaryApp)



    @Presubmit

    @FlakyTest(bugId = 241524174)

    @Test

    fun primaryAppBoundsIsVisibleAtEnd() = testSpec.splitAppLayerBoundsIsVisibleAtEnd(

        primaryApp, landscapePosLeft = !tapl.isTablet, portraitPosTop = true)

        primaryApp,

        landscapePosLeft = !tapl.isTablet,

        portraitPosTop = true

    )



    // TODO(b/246490534): Move back to presubmit after withAppTransitionIdle is robust enough to

    // get the correct end state.

    @FlakyTest(bugId = 246490534)

    @Test

    fun secondaryAppBoundsIsVisibleAtEnd() = testSpec.splitAppLayerBoundsIsVisibleAtEnd(

        secondaryApp, landscapePosLeft = tapl.isTablet, portraitPosTop = false)

        secondaryApp,

        landscapePosLeft = tapl.isTablet,

        portraitPosTop = false

    )



    @Presubmit

    @FlakyTest(bugId = 241524174)

    @Test

    fun primaryAppWindowIsVisibleAtEnd() = testSpec.appWindowIsVisibleAtEnd(primaryApp)



    @Presubmit

    @FlakyTest(bugId = 241524174)

    @Test

    fun secondaryAppWindowIsVisibleAtEnd() = testSpec.appWindowIsVisibleAtEnd(secondaryApp)
@@ -232,7 +238,8 @@ class SwitchAppByDoubleTapDivider(testSpec: FlickerTestParameter) : SplitScreenB 
            return FlickerTestParameterFactory.getInstance().getConfigNonRotationTests(

                // TODO(b/176061063):The 3 buttons of nav bar do not exist in the hierarchy.

                supportedNavigationModes =

                    listOf(WindowManagerPolicyConstants.NAV_BAR_MODE_GESTURAL_OVERLAY))

                listOf(WindowManagerPolicyConstants.NAV_BAR_MODE_GESTURAL_OVERLAY)

            )

        }

    }

}