Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a005a342 authored by shawnlin's avatar shawnlin
Browse files

Add more info to dump 

From bugreport, the ScreenDecorOverlay window was bigger than expected.

Dump each child view in the ScreenDecorOverlay window to check which
view goes wrong.

Bug: 231353329
Test: make
Change-Id: I01689e55c6bec64418c7a009d96b32aa1364e7ab
parent a3f6dae9

packages/SystemUI/src/com/android/systemui/ScreenDecorations.java

+13 −5
Original line number Diff line number Diff line
@@ -957,11 +957,19 @@ public class ScreenDecorations extends CoreStartable implements Tunable , Dumpab 
        } else {

            pw.println("  mScreenDecorHwcLayer: null");

        }

        if (mOverlays != null) {

            pw.println("  mOverlays(left,top,right,bottom)=("

                + (mOverlays != null && mOverlays[BOUNDS_POSITION_LEFT] != null) + ","

                + (mOverlays != null && mOverlays[BOUNDS_POSITION_TOP] != null) + ","

                + (mOverlays != null && mOverlays[BOUNDS_POSITION_RIGHT] != null) + ","

                + (mOverlays != null && mOverlays[BOUNDS_POSITION_BOTTOM] != null) + ")");

                    + (mOverlays[BOUNDS_POSITION_LEFT] != null) + ","

                    + (mOverlays[BOUNDS_POSITION_TOP] != null) + ","

                    + (mOverlays[BOUNDS_POSITION_RIGHT] != null) + ","

                    + (mOverlays[BOUNDS_POSITION_BOTTOM] != null) + ")");



            for (int i = BOUNDS_POSITION_LEFT; i < BOUNDS_POSITION_LENGTH; i++) {

                if (mOverlays[i] != null) {

                    mOverlays[i].dump(pw, getWindowTitleByPos(i));

                }

            }

        }

        mRoundedCornerResDelegate.dump(pw, args);

    }

packages/SystemUI/src/com/android/systemui/decor/OverlayWindow.kt

+11 −0
Original line number Diff line number Diff line
@@ -16,11 +16,13 @@ 
package com.android.systemui.decor



import android.annotation.IdRes

import android.annotation.NonNull

import android.content.Context

import android.view.Surface

import android.view.View

import android.view.ViewGroup

import com.android.systemui.RegionInterceptingFrameLayout

import java.io.PrintWriter



class OverlayWindow(private val context: Context) {
@@ -100,4 +102,13 @@ class OverlayWindow(private val context: Context) { 
            }

        }

    }



    fun dump(@NonNull pw: PrintWriter, name: String) {

        pw.println("  $name=")

        pw.println("    rootView=$rootView")

        for (i in 0 until rootView.childCount) {

            val child = rootView.getChildAt(i)

            pw.println("    child[$i]=$child")

        }

    }

}
 
 No newline at end of file