Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9fb3c882 authored by Svet Ganov's avatar Svet Ganov
Browse files

DO NOT MERGE Remove SUBSCRIBED_FEEDS permissions from framework 

b/20220885

Instead, move it to GSF:
ag/700092

SUBSCRIBED_FEEDS_READ/WRITE permissions guard the Content Provider
that stores sync feeds for 1p apps (Gmail, Claendar, etc).
The sync feeds are used for delivering and processing
GCM tickle-to-sync messages.

These permissions should not be used by 3rd parties but
if they were, this change will break them.

I don't know the reason these were not in GSF and 'signature'
to begin with. If someone does, please, comment.

Change-Id: I6c4e4c774fea12c7fe7082477c210ad75f007c66
parent e545bd36

core/res/AndroidManifest.xml

+0 −18
Original line number Diff line number Diff line
@@ -1603,24 +1603,6 @@ 
    <permission android:name="android.permission.WRITE_APN_SETTINGS"

        android:protectionLevel="signature|system" />



    <!-- Allows an application to allow access the subscribed feeds ContentProvider.

         @hide

         @removed

     -->

    <permission android:name="android.permission.SUBSCRIBED_FEEDS_READ"

        android:label="@string/permlab_subscribedFeedsRead"

        android:description="@string/permdesc_subscribedFeedsRead"

        android:protectionLevel="normal" />



    <!--

        @hide

        @removed

    -->

    <permission android:name="android.permission.SUBSCRIBED_FEEDS_WRITE"

        android:label="@string/permlab_subscribedFeedsWrite"

        android:description="@string/permdesc_subscribedFeedsWrite"

        android:protectionLevel="dangerous" />



    <!-- Allows applications to change network connectivity state -->

    <permission android:name="android.permission.CHANGE_NETWORK_STATE"

        android:description="@string/permdesc_changeNetworkState"

core/res/res/values/strings.xml

+0 −6
Original line number Diff line number Diff line
@@ -1301,12 +1301,6 @@ 
    <!-- Description of an application permission, listed so the user can choose whether they want to allow the application to do this. -->

    <string name="permdesc_readSyncStats">Allows an app to read the sync stats for an account, including the history of sync events and how much data is synced. </string>



    <!-- Title of an application permission, listed so the user can choose whether they want to allow the application to do this. -->

    <string name="permlab_subscribedFeedsWrite">write subscribed feeds</string>

    <!-- Description of an application permission, listed so the user can choose whether they want to allow the application to do this. -->

    <string name="permdesc_subscribedFeedsWrite">Allows the app to modify

        your currently synced feeds. Malicious apps may change your synced feeds.</string>



    <!-- Title of an application permission, listed so the user can choose whether they want to allow the application to do this. -->

    <string name="permlab_readDictionary">read terms you added to the dictionary</string>

    <!-- Description of an application permission, listed so the user can choose whether they want to allow the application to do this. -->