Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9eeb5923 authored by Eric Miao's avatar Eric Miao
Browse files

Add a readonly version for flags in libcore 

Bug: 368409430
Flag: EXEMPT bugfix

The exported flag native_metrics from com.android.libcore breaks
some use cases of Isolated Process as reading of the flag requires
I/O permission which Isolated Processes don't have.  In this CL,
we added a readonly version of the flags in libcore, and use
`force-read-only` mode, the resulting generated code will return
the values hardcoded. This prevents reading of the flag value
from storage, and thus allows Isolated Process to work.

Access to the flag will be done by:

  com.android.libcore.readonly.Flags.nativeMetrics()
  com.android.libcore.readonly.Flags.postCleanupApis()

This readonly flags will be kept to be synced with the one in libcore.
Once the new aconfig API is landed, there will be no need to keep the
readonly version, and thus this CL can be reverted.

Change-Id: If4c56dae63be879b54f951bb8c7904ca3b98607e
parent 21754b02

AconfigFlags.bp

+21 −0
Original line number Diff line number Diff line
@@ -107,6 +107,7 @@ aconfig_declarations_group { 
        "hwui_flags_java_lib",

        "interaction_jank_monitor_flags_lib",

        "libcore_exported_aconfig_flags_lib",

        "libcore_readonly_aconfig_flags_lib",

        "libgui_flags_java_lib",

        "power_flags_lib",

        "sdk_sandbox_flags_lib",
@@ -166,6 +167,26 @@ java_aconfig_library { 
    defaults: ["framework-minus-apex-aconfig-java-defaults"],

}



// See b/368409430 - This is for libcore flags to be generated with

// force-read-only mode, so access to the flags does not involve I/O,

// which could break Isolated Processes with I/O permission disabled.

// The issue will be addressed once new Aconfig storage API is landed

// and the readonly version will be removed.

aconfig_declarations {

    name: "libcore-readonly-aconfig-flags",

    package: "com.android.libcore.readonly",

    container: "system",

    srcs: ["libcore-readonly.aconfig"],

}



// Core Libraries / libcore

java_aconfig_library {

    name: "libcore_readonly_aconfig_flags_lib",

    aconfig_declarations: "libcore-readonly-aconfig-flags",

    mode: "force-read-only",

    defaults: ["framework-minus-apex-aconfig-java-defaults"],

}



// Telecom

java_aconfig_library {

    name: "telecom_flags_core_java_lib",

libcore-readonly.aconfig

0 → 100644
+25 −0
Original line number Diff line number Diff line 
package: "com.android.libcore.readonly"

container: "system"



# These are the read-only version of the aconfig flags in com.android.libcore

# that will be built with 'force-read-only' mode.

# See b/368409430 - these flags will be removed once the new aconfig API landed.

flag {

    namespace: "core_libraries"

    name: "post_cleanup_apis"

    is_exported: false

    description: "This flag includes APIs to add/remove/call callbacks post-cleanup"

    bug: "331243037"

    # APIs provided by a mainline module can only use a frozen flag.

    is_fixed_read_only: true

}



flag {

    namespace: "core_libraries"

    name: "native_metrics"

    is_exported: false

    description: "This flag includes APIs fo maintaining and exposing native allocation metrics"

    bug: "331243037"

    # APIs provided by a mainline module can only use a frozen flag.

    is_fixed_read_only: true

}