Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e62c311 authored by Edman Anjos's avatar Edman Anjos
Browse files

Update in DPM delegation documentation. 

Add note on DPM#setDelegatedScopes documentation regarding the
broadcast sent to the delegate package to notify its new scopes; and
change the admin ComponentName annotation to @Nullable in
DPM#getDelegatedScopes.

Bug: 33099995
Test: cts-tradefed run cts-dev --module CtsDevicePolicyManagerTestCases --test com.android.cts.devicepolicy.MixedDeviceOwnerTest#testDelegation
Change-Id: I28fe3a631c05a9e6b8dae766ce6c42881f2e3a00
parent a5ec280b

core/java/android/app/admin/DevicePolicyManager.java

+10 −5
Original line number Diff line number Diff line
@@ -1177,9 +1177,9 @@ public class DevicePolicyManager { 
            = "android.app.action.SHOW_DEVICE_MONITORING_DIALOG";



    /**

     * Broadcast Action: Sent after application delegation scopes are changed. The new list of

     * delegation scopes will be sent in an extra identified by the {@link #EXTRA_DELEGATION_SCOPES}

     * key.

     * Broadcast Action: Sent after application delegation scopes are changed. The new delegation

     * scopes will be sent in an {@code ArrayList<String>} extra identified by the

     * {@link #EXTRA_DELEGATION_SCOPES} key.

     *

     * <p class=”note”> Note: This is a protected intent that can only be sent by the system.</p>

     */
@@ -1188,7 +1188,7 @@ public class DevicePolicyManager { 
            "android.app.action.APPLICATION_DELEGATION_SCOPES_CHANGED";



    /**

     * A list of Strings corresponding to the delegation scopes given to an app in the

     * An {@code ArrayList<String>} corresponding to the delegation scopes given to an app in the

     * {@link #ACTION_APPLICATION_DELEGATION_SCOPES_CHANGED} broadcast.

     */

    public static final String EXTRA_DELEGATION_SCOPES = "android.app.extra.DELEGATION_SCOPES";
@@ -3669,6 +3669,11 @@ public class DevicePolicyManager { 
     * Granted APIs are determined by {@code scopes}, which is a list of the {@code DELEGATION_*}

     * constants.

     * <p>

     * A broadcast with the {@link #ACTION_APPLICATION_DELEGATION_SCOPES_CHANGED} action will be

     * sent to the {@code delegatePackage} with its new scopes in an {@code ArrayList<String>} extra

     * under the {@link #EXTRA_DELEGATION_SCOPES} key. The broadcast is sent with the

     * {@link Intent#FLAG_RECEIVER_REGISTERED_ONLY} flag.

     * <p>

     * Delegated scopes are a per-user state. The delegated access is persistent until it is later

     * cleared by calling this method with an empty {@code scopes} list or uninstalling the

     * {@code delegatePackage}.
@@ -3704,7 +3709,7 @@ public class DevicePolicyManager { 
     * @throws SecurityException if {@code admin} is not a device or a profile owner.

     */

     @NonNull

     public List<String> getDelegatedScopes(@NonNull ComponentName admin,

     public List<String> getDelegatedScopes(@Nullable ComponentName admin,

             @NonNull String delegatedPackage) {

         throwIfParentInstance("getDelegatedScopes");

         if (mService != null) {

services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java

+2 −2
Original line number Diff line number Diff line
@@ -4887,7 +4887,7 @@ public class DevicePolicyManagerService extends IDevicePolicyManager.Stub { 
            // Set the new delegate in user policies.

            final DevicePolicyData policy = getUserData(userId);

            if (!scopes.isEmpty()) {

                policy.mDelegationMap.put(delegatePackage, scopes);

                policy.mDelegationMap.put(delegatePackage, new ArrayList<>(scopes));

            } else {

                // Remove any delegation info if the given scopes list is empty.

                policy.mDelegationMap.remove(delegatePackage);