Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e59e12b authored by Paul Jensen's avatar Paul Jensen
Browse files

Deprecate ConnectivityManager.isNetworkTypeValid as it's unneeded. 

All ConnectivityManager APIs taking a network type have been
deprecated so there should be no need to validate a network type.

bug:20647016
Change-Id: I2dcf24f58016e94aa814dda38cfc848366cc461c
parent 424681e4

api/current.txt

+1 −1
Original line number Diff line number Diff line
@@ -18361,7 +18361,7 @@ package android.net { 
    method public void ignoreNetworkWithCaptivePortal(android.net.Network, java.lang.String);

    method public boolean isActiveNetworkMetered();

    method public boolean isDefaultNetworkActive();

    method public static boolean isNetworkTypeValid(int);

    method public static deprecated boolean isNetworkTypeValid(int);

    method public void registerNetworkCallback(android.net.NetworkRequest, android.net.ConnectivityManager.NetworkCallback);

    method public void releaseNetworkRequest(android.app.PendingIntent);

    method public void removeDefaultNetworkActiveListener(android.net.ConnectivityManager.OnNetworkActiveListener);

api/system-current.txt

+1 −1
Original line number Diff line number Diff line
@@ -19829,7 +19829,7 @@ package android.net { 
    method public void ignoreNetworkWithCaptivePortal(android.net.Network, java.lang.String);

    method public boolean isActiveNetworkMetered();

    method public boolean isDefaultNetworkActive();

    method public static boolean isNetworkTypeValid(int);

    method public static deprecated boolean isNetworkTypeValid(int);

    method public void registerNetworkCallback(android.net.NetworkRequest, android.net.ConnectivityManager.NetworkCallback);

    method public void releaseNetworkRequest(android.app.PendingIntent);

    method public void removeDefaultNetworkActiveListener(android.net.ConnectivityManager.OnNetworkActiveListener);

core/java/android/net/ConnectivityManager.java

+2 −0
Original line number Diff line number Diff line
@@ -496,6 +496,8 @@ public class ConnectivityManager { 
     * Tests if a given integer represents a valid network type.

     * @param networkType the type to be tested

     * @return a boolean.  {@code true} if the type is valid, else {@code false}

     * @deprecated All APIs accepting a network type are deprecated. There should be no need to

     *             validate a network type.

     */

    public static boolean isNetworkTypeValid(int networkType) {

        return networkType >= 0 && networkType <= MAX_NETWORK_TYPE;