Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e397775 authored by Jake Hamby's avatar Jake Hamby
Browse files

Fix Javadoc param tags and typo in private constant definition. 

- Two Javadoc comments in telephony/cdma/SmsMessage.java had the wrong parameter name in @param.
- Typo in private constant defined in telephony/cdma/sms/BearerData.java.

Change-Id: I3c210383f74a5fef022e0958ab56ef9b7be8e97c
parent bcd57322

telephony/java/com/android/internal/telephony/cdma/SmsMessage.java

+2 −2
Original line number Diff line number Diff line
@@ -283,7 +283,7 @@ public class SmsMessage extends SmsMessageBase { 
     * @param destAddr              Address of the recipient.

     * @param message               String representation of the message payload.

     * @param statusReportRequested Indicates whether a report is requested for this message.

     * @param headerData            Array containing the data for the User Data Header, preceded

     * @param smsHeader             Array containing the data for the User Data Header, preceded

     *                              by the Element Identifiers.

     * @return a <code>SubmitPdu</code> containing the encoded SC

     *         address, if applicable, and the encoded message.
@@ -351,7 +351,7 @@ public class SmsMessage extends SmsMessageBase { 
     * Get an SMS-SUBMIT PDU for a data message to a destination address &amp; port

     *

     * @param destAddr the address of the destination for the message

     * @param userDara the data for the message

     * @param userData the data for the message

     * @param statusReportRequested Indicates whether a report is requested for this message.

     * @return a <code>SubmitPdu</code> containing the encoded SC

     *         address, if applicable, and the encoded message.

telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java

+2 −3
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ import android.text.format.Time; 
import com.android.internal.telephony.IccUtils;

import com.android.internal.telephony.GsmAlphabet;

import com.android.internal.telephony.SmsHeader;

import com.android.internal.telephony.cdma.sms.UserData;

import com.android.internal.telephony.SmsMessageBase.TextEncodingDetails;



import com.android.internal.util.BitwiseInputStream;
@@ -49,7 +48,7 @@ public final class BearerData { 
     */

    private final static byte SUBPARAM_MESSAGE_IDENTIFIER               = 0x00;

    private final static byte SUBPARAM_USER_DATA                        = 0x01;

    private final static byte SUBPARAM_USER_REPONSE_CODE                = 0x02;

    private final static byte SUBPARAM_USER_RESPONSE_CODE               = 0x02;

    private final static byte SUBPARAM_MESSAGE_CENTER_TIME_STAMP        = 0x03;

    private final static byte SUBPARAM_VALIDITY_PERIOD_ABSOLUTE         = 0x04;

    private final static byte SUBPARAM_VALIDITY_PERIOD_RELATIVE         = 0x05;
@@ -1551,7 +1550,7 @@ public final class BearerData { 
                case SUBPARAM_USER_DATA:

                    decodeSuccess = decodeUserData(bData, inStream);

                    break;

                case SUBPARAM_USER_REPONSE_CODE:

                case SUBPARAM_USER_RESPONSE_CODE:

                    decodeSuccess = decodeUserResponseCode(bData, inStream);

                    break;

                case SUBPARAM_REPLY_OPTION: