Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e1923d0 authored by Adam Lesinski's avatar Adam Lesinski
Browse files

AAPT: Remove warnings for public resources without comments 

There are so many public resources that do not warrant comments
that having a warning that no one cares about is just producing
log spam.

Bug:21495023
Change-Id: I84e3b39c7139ee67fb5cb711d5ab466d8f4ef2e0
parent 59e04c6f

tools/aapt/Resource.cpp

+0 −10
Original line number Original line Diff line number Diff line
@@ -1883,8 +1883,6 @@ status_t buildResources(Bundle* bundle, const sp<AaptAssets>& assets, sp<ApkBuil 
                    //printf("Comment of %s: %s\n", String8(e).string(),

                    //printf("Comment of %s: %s\n", String8(e).string(),

                    //        String8(cmt).string());

                    //        String8(cmt).string());

                    syms->appendComment(String8(e), String16(cmt), srcPos);

                    syms->appendComment(String8(e), String16(cmt), srcPos);

                } else {

                    //printf("No comment for %s\n", String8(e).string());

                }

                }

                syms->makeSymbolPublic(String8(e), srcPos);

                syms->makeSymbolPublic(String8(e), srcPos);

            } else if (strcmp16(block.getElementName(&len), uses_permission16.string()) == 0) {

            } else if (strcmp16(block.getElementName(&len), uses_permission16.string()) == 0) {
@@ -2535,10 +2533,6 @@ static status_t writeSymbolClass( 
            fprintf(fp,

            fprintf(fp,

                    "%s/** %s\n",

                    "%s/** %s\n",

                    getIndentSpace(indent), cmt.string());

                    getIndentSpace(indent), cmt.string());

        } else if (sym.isPublic && !includePrivate) {

            sym.sourcePos.warning("No comment for public symbol %s:%s/%s",

                assets->getPackage().string(), className.string(),

                String8(sym.name).string());

        }

        }

        String16 typeComment(sym.typeComment);

        String16 typeComment(sym.typeComment);

        if (typeComment.size() > 0) {

        if (typeComment.size() > 0) {
@@ -2581,10 +2575,6 @@ static status_t writeSymbolClass( 
                     "%s */\n",

                     "%s */\n",

                    getIndentSpace(indent), cmt.string(),

                    getIndentSpace(indent), cmt.string(),

                    getIndentSpace(indent));

                    getIndentSpace(indent));

        } else if (sym.isPublic && !includePrivate) {

            sym.sourcePos.warning("No comment for public symbol %s:%s/%s",

                assets->getPackage().string(), className.string(),

                String8(sym.name).string());

        }

        }

        ann.printAnnotations(fp, getIndentSpace(indent));

        ann.printAnnotations(fp, getIndentSpace(indent));

        fprintf(fp, "%spublic static final String %s=\"%s\";\n",

        fprintf(fp, "%spublic static final String %s=\"%s\";\n",