Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e17af40 authored by Caitlin Shkuratov's avatar Caitlin Shkuratov
Browse files

Update test TableLogBuffers to use LogProxyDefault. 

Unit tests will automatically echo android.util.Log statements to the
output, and we want TableLogBuffer content to be part of that output as
well. FakeLogProxy doesn't do that echo-ing, so we actually want the
real LogProxyDefault in tests so the buffer is logged to logcat and
available in test runs.

Bug: EXEMPT test fix
Flag: TEST_ONLY
Test: atest BatteryRepositoryTest -> verify TableLogBuffer content is in
output in studio
Test: atest TableLogBufferFactoryImplTest still passes

Change-Id: Icb06bf4d7961e0dcf1c1f41444c95343852da8e1
parent 61a4cd44

packages/SystemUI/tests/utils/src/com/android/systemui/log/table/TableLogBufferFactoryKosmos.kt

+2 −2
Original line number Diff line number Diff line
@@ -18,8 +18,8 @@ package com.android.systemui.log.table 


import com.android.systemui.dump.dumpManager

import com.android.systemui.kosmos.Kosmos

import com.android.systemui.log.FakeLogProxy

import com.android.systemui.log.LogcatEchoTrackerAlways

import com.android.systemui.log.impl.LogProxyDefault

import com.android.systemui.log.table.impl.TableLogBufferFactoryImpl

import com.android.systemui.util.time.fakeSystemClock
@@ -29,6 +29,6 @@ val Kosmos.tableLogBufferFactory: TableLogBufferFactory by 
            dumpManager = dumpManager,

            systemClock = fakeSystemClock,

            logcatEchoTracker = LogcatEchoTrackerAlways(),

            logProxy = FakeLogProxy(),

            logProxy = LogProxyDefault(),

        )

    }

packages/SystemUI/tests/utils/src/com/android/systemui/log/table/TableLogBufferHelper.kt

+2 −2
Original line number Diff line number Diff line
@@ -17,8 +17,8 @@ 
package com.android.systemui.log.table



import com.android.systemui.kosmos.Kosmos

import com.android.systemui.log.FakeLogProxy

import com.android.systemui.log.LogcatEchoTrackerAlways

import com.android.systemui.log.impl.LogProxyDefault

import com.android.systemui.util.time.SystemClock

import com.android.systemui.util.time.fakeSystemClock
@@ -39,5 +39,5 @@ fun logcatTableLogBuffer(systemClock: SystemClock, name: String = "EchoToLogcatT 
        name,

        systemClock,

        logcatEchoTracker = LogcatEchoTrackerAlways(),

        localLogcat = FakeLogProxy(),

        localLogcat = LogProxyDefault(),

    )