diff --git a/services/core/java/com/android/server/pm/PackageDexOptimizer.java b/services/core/java/com/android/server/pm/PackageDexOptimizer.java index 6ae05ff50455a04192dc9a1603d9ed7ec33334e8..efd658a0e866d41dc2a7bbb91f4aace92f19d7c6 100644 --- a/services/core/java/com/android/server/pm/PackageDexOptimizer.java +++ b/services/core/java/com/android/server/pm/PackageDexOptimizer.java @@ -271,10 +271,7 @@ public class PackageDexOptimizer { return DEX_OPT_SKIPPED; } - // TODO(calin): there's no need to try to create the oat dir over and over again, - // especially since it involve an extra installd call. We should create - // if (if supported) on the fly during the dexopt call. - String oatDir = createOatDirIfSupported(pkg, isa); + String oatDir = getPackageOatDirIfSupported(pkg); Log.i(TAG, "Running dexopt (dexoptNeeded=" + dexoptNeeded + ") on: " + path + " pkg=" + pkg.applicationInfo.packageName + " isa=" + isa @@ -639,7 +636,7 @@ public class PackageDexOptimizer { } /** - * Creates oat dir for the specified package if needed and supported. + * Gets oat dir for the specified package if needed and supported. * In certain cases oat directory * cannot be created: * * - * @return Absolute path to the oat directory or null, if oat directory - * cannot be created. + * @return Absolute path to the oat directory or null, if oat directories + * not needed or unsupported for the package. */ @Nullable - private String createOatDirIfSupported(PackageParser.Package pkg, String dexInstructionSet) { + private String getPackageOatDirIfSupported(PackageParser.Package pkg) { if (!pkg.canHaveOatDir()) { return null; } File codePath = new File(pkg.codePath); - if (codePath.isDirectory()) { - // TODO(calin): why do we create this only if the codePath is a directory? (i.e for - // cluster packages). It seems that the logic for the folder creation is - // split between installd and here. - File oatDir = getOatDir(codePath); - try { - mInstaller.createOatDir(oatDir.getAbsolutePath(), dexInstructionSet); - } catch (InstallerException e) { - Slog.w(TAG, "Failed to create oat dir", e); - return null; - } - return oatDir.getAbsolutePath(); + if (!codePath.isDirectory()) { + return null; } - return null; + return getOatDir(codePath).getAbsolutePath(); } static File getOatDir(File codePath) {