Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9dacef98 authored by Julia Tuttle's avatar Julia Tuttle
Browse files

Flexiglass: fix occasional squished notifs on lockscreen 

We were skipping one updateStackPosition() call to avoid flicker, but at
least occasionally, we were skipping *necessary* calls and ending up
with a mis-sized stack and squished notifications as a result.

Fixes: 352281989
Test: manual: see b/352281989#comment2 for repro steps
Flag: com.android.systemui.scene_container
Change-Id: I3c23abe7243a41176f6038be55a3ff08cf2e5c4d
parent ae8992e2

packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java

+1 −6
Original line number Diff line number Diff line
@@ -1544,12 +1544,7 @@ public class NotificationStackScrollLayout 
    public void setExpandedHeight(float height) {

        final boolean skipHeightUpdate = shouldSkipHeightUpdate();



        // when scene framework is enabled and in single shade, updateStackPosition is already

        // called by updateTopPadding every time the stack moves, so skip it here to avoid

        // flickering.

        if (!SceneContainerFlag.isEnabled() || mShouldUseSplitNotificationShade) {

        updateStackPosition();

        }



        if (!skipHeightUpdate) {

            mExpandedHeight = height;