Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d552951 authored by Wenhui Yang's avatar Wenhui Yang
Browse files

Fix the biometrics prompt talkback 

Fix the duplicate talkback focuses on fingerprint icon and change the talkback message per Kerry's suggestion

Test: Manual - Open biometrics prompt and observe the duplicate focuses of decorative fingerprint icon has been removed and talkback announces the animation the same as the education during enrollment.
Fixes: 267407905

Change-Id: Ib2683cbf7a0ca409002b576a7bbcf1fe41808ca7
parent e56827c6

packages/SystemUI/res/values/strings.xml

+6 −2
Original line number Diff line number Diff line
@@ -405,8 +405,12 @@ 


    <!-- Message shown when the system-provided fingerprint dialog is shown, asking for authentication -->

    <string name="fingerprint_dialog_touch_sensor">Touch the fingerprint sensor</string>

    <!-- Content description of the fingerprint icon when the system-provided fingerprint dialog is showing, for accessibility (not shown on the screen). [CHAR LIMIT=NONE] -->

    <string name="accessibility_fingerprint_dialog_fingerprint_icon">Fingerprint icon</string>

    <!-- Content description of the fingerprint icon when the system-provided fingerprint dialog is showing, to locate the sensor (tablet) for accessibility (not shown on the screen). [CHAR LIMIT=NONE]-->

    <string name="security_settings_sfps_enroll_find_sensor_message" product="tablet">The fingerprint sensor is on the power button. It’s the flat button next to the raised volume button on the edge of the tablet.\n\nPressing the power button turns off the screen.</string>

    <!-- Content description of the fingerprint icon when the system-provided fingerprint dialog is showing, to locate the sensor (device) for accessibility (not shown on the screen). [CHAR LIMIT=NONE]-->

    <string name="security_settings_sfps_enroll_find_sensor_message" product="device">The fingerprint sensor is on the power button. It’s the flat button next to the raised volume button on the edge of the device.\n\nPressing the power button turns off the screen.</string>

    <!-- Content description of the fingerprint icon when the system-provided fingerprint dialog is showing, to locate the sensor (default) for accessibility (not shown on the screen). [CHAR LIMIT=NONE]-->

    <string name="security_settings_sfps_enroll_find_sensor_message" product="default">The fingerprint sensor is on the power button. It’s the flat button next to the raised volume button on the edge of the phone.\n\nPressing the power button turns off the screen.</string>

    <!-- Message shown to inform the user a face cannot be recognized and fingerprint should instead be used.[CHAR LIMIT=50] -->

    <string name="fingerprint_dialog_use_fingerprint_instead">Can\u2019t recognize face. Use fingerprint instead.</string>

    <!-- Message shown to inform the user a face cannot be recognized and fingerprint should instead be used.[CHAR LIMIT=50] -->

packages/SystemUI/src/com/android/systemui/biometrics/AuthBiometricFingerprintIconController.kt

+1 −2
Original line number Diff line number Diff line
@@ -97,7 +97,6 @@ open class AuthBiometricFingerprintIconController( 
        val iconContentDescription = getIconContentDescription(newState)

        if (iconContentDescription != null) {

            iconView.contentDescription = iconContentDescription

            iconViewOverlay.contentDescription = iconContentDescription

        }



        iconView.frame = 0
@@ -152,7 +151,7 @@ open class AuthBiometricFingerprintIconController( 
            STATE_AUTHENTICATING_ANIMATING_IN,

            STATE_AUTHENTICATING,

            STATE_PENDING_CONFIRMATION,

            STATE_AUTHENTICATED -> R.string.accessibility_fingerprint_dialog_fingerprint_icon

            STATE_AUTHENTICATED -> R.string.security_settings_sfps_enroll_find_sensor_message

            STATE_ERROR,

            STATE_HELP -> R.string.biometric_dialog_try_again

            else -> null