Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d460d8f authored by Mateusz Cicheński's avatar Mateusz Cicheński
Browse files

Always invoke show on the dismiss target for pip. 

Previously, if the user moved pip, and then started moving it again
before the dismiss target hide animation finished, the dismiss target
would not show up again, since it was still VISIBLE.

Test: manually, open pip and move it around, dismiss target always shows up
Bug: 242616699

Change-Id: Iac288f5855f0d26075113e795dd2b88b6a152275
parent dc0b0fd9

libs/WindowManager/Shell/src/com/android/wm/shell/pip/phone/PipDismissTargetHandler.java

+3 −1
Original line number Diff line number Diff line
@@ -288,8 +288,10 @@ public class PipDismissTargetHandler implements ViewTreeObserver.OnPreDrawListen 


        if (mTargetViewContainer.getVisibility() != View.VISIBLE) {

            mTargetViewContainer.getViewTreeObserver().addOnPreDrawListener(this);

            mTargetViewContainer.show();

        }

        // always invoke show, since the target might still be VISIBLE while playing hide animation,

        // so we want to ensure it will show back again

        mTargetViewContainer.show();

    }



    /** Animates the magnetic dismiss target out and then sets it to GONE. */