Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cfeb6ec authored by Basavapatna Dattaguru's avatar Basavapatna Dattaguru
Browse files

VideoEditor:Issue ID: 3431967 

Fixes memory leak in getProperties
Updated with Review comments

Change-Id: Ie4e8edaee1c76f18d0526b5eae9f9a128e0a3c17
parent 439f5c6b

media/jni/mediaeditor/VideoEditorPropertiesMain.cpp

+18 −4
Original line number Diff line number Diff line
@@ -122,12 +122,26 @@ jobject videoEditProp_getProperties( 
            &gotten, pEnv, file, NULL, M4OSA_NULL);



    result = M4OSA_fileReadOpen(&context, (M4OSA_Void*)pFile, M4OSA_kFileRead);



    if(M4NO_ERROR != result) {

        // Free the file path.

        videoEditOsal_free(pFile);

        pFile = M4OSA_NULL;

    }



    videoEditJava_checkAndThrowIllegalArgumentException(&gotten, pEnv,

        (M4NO_ERROR != result), "file not found");

    if(M4NO_ERROR != result)

        return(properties);



    // Close the file and free the file context

    if (context != NULL) {

        result = M4OSA_fileReadClose(context);

        context = M4OSA_NULL;

    }



    // Return if Error

    if (M4NO_ERROR != result) {

        return (properties); // NULL

    }



    // Check if the file path is valid.

    if (gotten)