Fix to NullPointerException on move back in ActivityStack.
In ActivityTask.moveTaskToBackLocked NullPointerException may occur when moving back with only current Activity in stack. This due to a condition that may trigger despite a TaskRecord being null and then attempt accessing the TaskRecord.mOnTopOfHome variable. TaskRecord task may be set to null when no resumed activity remain. Resolved by assuring that flag mOnTopOfHome is instead set to false for current TaskRecord in case where there are no remaining activities above home. The above bug has already been corrected in the following commit, ada62fca, but it does not set the cottect value to mTopOfHome for the current taks, see below. Variable mOnTopOfHome will not be set to false in situations where stack is of size 1 or less and task is null, perhaps from already having finished current activity. To avoid current TaskRecord maintaining value mOnTopOfHome to true after launching Home this variable is set to false. Impact should not be major due to correction earlier that makes sure that there is always a TaskRecord.mOnTopOfHome set to true above Home activity but if not correctly set for current task still gives a possibility of bad behavior. Change-Id: Ie86ad99c188aaa05b0de9d58eaa16c42b6fc4341
Loading
Please register or sign in to comment