Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cc3b842 authored by Daniel Akinola's avatar Daniel Akinola
Browse files

Update "Open in Browser" dialog to meet a11y guideline 

* Updating OK button to be 48dp height
* Updating line height of description text so that when font size is
  max, words don't overlap

Fix: 397859648
Fix: 397866754
Test: Open Youtube in desktop windowing and click gear icon to launch
dialog
Flag: EXEMPT bugfix

Change-Id: I3e6beae488bc6856930c3a401e5e6798d11cc7fc
parent e2820723

libs/WindowManager/Shell/res/layout/open_by_default_settings_dialog.xml

+5 −4
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ 
                    android:layout_height="wrap_content"

                    android:textSize="12sp"

                    android:textFontWeight="400"

                    android:lineHeight="16dp"

                    android:lineHeight="28dp"

                    android:layout_gravity="center_horizontal"

                    android:layout_marginBottom="16dp"

                    android:textColor="@androidprv:color/materialColorOnSurfaceVariant"
@@ -113,12 +113,13 @@ 
                <Button

                    android:id="@+id/open_by_default_settings_dialog_confirm_button"

                    android:layout_width="wrap_content"

                    android:layout_height="36dp"

                    android:layout_height="wrap_content"

                    android:minHeight="48dp"

                    android:text="@string/open_by_default_dialog_dismiss_button_text"

                    android:layout_gravity="end"

                    android:layout_marginHorizontal="24dp"

                    android:layout_marginTop="32dp"

                    android:layout_marginBottom="24dp"

                    android:layout_marginTop="26dp"

                    android:layout_marginBottom="18dp"

                    android:textSize="14sp"

                    android:textFontWeight="500"

                    android:textColor="@androidprv:color/materialColorOnPrimary"