Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9c4b4e14 authored by Vania Desmonda's avatar Vania Desmonda
Browse files

Avoid calling updateSurface twice when dimming is applied. 

Test: manual, atest WallpaperManagerServiceTest
Bug: 229715857
Change-Id: Ib8c4939fea503ee71bf71a95dc71f10fd2956614
parent a61b748e

core/java/android/service/wallpaper/WallpaperService.java

+1 −1
Original line number Diff line number Diff line
@@ -904,7 +904,6 @@ public abstract class WallpaperService extends Service { 
            // based on its default wallpaper color hints.

            mShouldDim = dimAmount != 0f || mShouldDimByDefault;

            updateSurfaceDimming();

            updateSurface(false, false, true);

        }



        private void updateSurfaceDimming() {
@@ -941,6 +940,7 @@ public abstract class WallpaperService extends Service { 
            } else {

                Log.v(TAG, "Setting wallpaper dimming: " + 0);

                surfaceControlTransaction.setAlpha(mBbqSurfaceControl, 1.0f).apply();

                updateSurface(false, false, true);

            }



            mPreviousWallpaperDimAmount = mWallpaperDimAmount;